Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bootstrap_servers argument usage without quotes #93

Closed
g-despot opened this issue Feb 14, 2022 · 0 comments · Fixed by #98
Closed

Allow bootstrap_servers argument usage without quotes #93

g-despot opened this issue Feb 14, 2022 · 0 comments · Fixed by #98
Assignees
Labels
good first issue good first issue type: enhancement New feature or request

Comments

@g-despot
Copy link
Contributor

g-despot commented Feb 14, 2022

When creating a stream, the bootstrap_servers argument needs to be specified with quotes around it:

stream = MemgraphKafkaStream(
    name="ratings_stream",
    topics=["ratings"],
    transform="movielens.rating",
    bootstrap_servers="'kafka:9092'",
)
memgraph.create_stream(stream)

This can sometimes be misleading and users will maybe pass a plain string without the additional quotes. Both options need to be handled in the background and adjusted to the proper Cypher syntax.

Additionally, passing multiple bootstrap servers should be allowed in the form of a list of strings:

stream = MemgraphKafkaStream(
    name="ratings_stream",
    topics=["ratings"],
    transform="movielens.rating",
    bootstrap_servers=["kafka:9092", "kafka:9093"],
)
memgraph.create_stream(stream)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue good first issue type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants