Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashmap get unchecked #9

Closed
wants to merge 2 commits into from
Closed

Hashmap get unchecked #9

wants to merge 2 commits into from

Conversation

folkertdev
Copy link
Collaborator

This

  • combines the hashmap fields into their own struct (clearer, and useful for testing)
  • uses unchecked access into the hashmap (the index is a u16, and the length of the array is usize::MAX or larger)

This marginally improves performance for compression level 9, uses fewer instructions, but uses more unsafe. We'll need a better benchmarking setup to confidently say that this tradeoff is worth it.

Copy link

codecov bot commented Jan 19, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@folkertdev folkertdev closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant