-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added message validation #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idanasulin2706
approved these changes
Nov 6, 2022
idanasulin2706
added a commit
that referenced
this pull request
Nov 6, 2022
* update examples + readme * swap . with # in for publish/consume in station & consumer names * update example files * Fix consumerName/Group conversions * type annotation successfully added * updated readme * Use station/consumer internal names for NATS communication * Fix internal name conversion * Update README.md * Update README.md * Updated Types and created consume message anotation * project rebuilt * transporter initialized * Repo updated * updated readme * updated readme * fixed const issue * made further fixes * further fixes * deleted unused import packages@ * deleted and rebuilt the folder * Create Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * readme fixes * readme improvements * add support for generating unique suffix for prod/cons * update readme + js docs * lic change * support for async produce * bugfixes * Headers support for messages sdk (#77) * add prefix $memphis to keys in header * headers support for messages * add a producer example * fix issues * update readme * update examples * fix export issue Co-authored-by: idanasulinStrech <idan@memphis.dev> * add get headers func (#78) * add get headers func * add js docs Co-authored-by: idanasulinStrech <idan@memphis.dev> * added support for schema updates (#79) * added support for schema updates * fixed small bugs * added message validation * fixed bugs + added support for object msg * fixed bugs * small fixes * some more changes * update docs * add build files Co-authored-by: shay23b <shay.b@strech.io> Co-authored-by: idanasulinStrech <idan@memphis.dev> * Update README.md * small bug fix -> should drop listener (#80) Co-authored-by: shay23b <shay.b@strech.io> * update example files * schema validation bugfix * schema validation bugfix - invalid protobuf * added message validation (#81) Co-authored-by: shay23b <shay.b@strech.io> * update build files * added object err handle (#83) * added object err handle * version * build files Co-authored-by: idanasulinStrech <idan@memphis.dev> Co-authored-by: Or Grinberg <or@memphis.dev> Co-authored-by: taiwo truth <taiwotruth@gmail.com> Co-authored-by: Yaniv Ben Hemo <70286779+yanivbh1@users.noreply.github.com> Co-authored-by: Valera Bronshtein <105710429+valeraBr@users.noreply.github.com> Co-authored-by: Yaniv Ben Hemo <Yaniv@memphis.dev> Co-authored-by: shohamroditimemphis <108217318+shohamroditimemphis@users.noreply.github.com> Co-authored-by: Shay Bratslavsky <shay@memphis.dev> Co-authored-by: shay23b <shay.b@strech.io>
idanasulin2706
added a commit
that referenced
this pull request
Nov 6, 2022
* update examples + readme * swap . with # in for publish/consume in station & consumer names * update example files * Fix consumerName/Group conversions * type annotation successfully added * updated readme * Use station/consumer internal names for NATS communication * Fix internal name conversion * Update README.md * Update README.md * Updated Types and created consume message anotation * project rebuilt * transporter initialized * Repo updated * updated readme * updated readme * fixed const issue * made further fixes * further fixes * deleted unused import packages@ * deleted and rebuilt the folder * Create Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * readme fixes * readme improvements * add support for generating unique suffix for prod/cons * update readme + js docs * lic change * support for async produce * bugfixes * Headers support for messages sdk (#77) * add prefix $memphis to keys in header * headers support for messages * add a producer example * fix issues * update readme * update examples * fix export issue Co-authored-by: idanasulinStrech <idan@memphis.dev> * add get headers func (#78) * add get headers func * add js docs Co-authored-by: idanasulinStrech <idan@memphis.dev> * added support for schema updates (#79) * added support for schema updates * fixed small bugs * added message validation * fixed bugs + added support for object msg * fixed bugs * small fixes * some more changes * update docs * add build files Co-authored-by: shay23b <shay.b@strech.io> Co-authored-by: idanasulinStrech <idan@memphis.dev> * Update README.md * small bug fix -> should drop listener (#80) Co-authored-by: shay23b <shay.b@strech.io> * update example files * schema validation bugfix * schema validation bugfix - invalid protobuf * added message validation (#81) Co-authored-by: shay23b <shay.b@strech.io> * update build files * added object err handle (#83) * added object err handle * version * build files Co-authored-by: idanasulinStrech <idan@memphis.dev> * Update Jenkinsfile (#85) * Update Jenkinsfile (#86) * access undefined field bugfix Co-authored-by: Or Grinberg <or@memphis.dev> Co-authored-by: taiwo truth <taiwotruth@gmail.com> Co-authored-by: Yaniv Ben Hemo <70286779+yanivbh1@users.noreply.github.com> Co-authored-by: Valera Bronshtein <105710429+valeraBr@users.noreply.github.com> Co-authored-by: Yaniv Ben Hemo <Yaniv@memphis.dev> Co-authored-by: shohamroditimemphis <108217318+shohamroditimemphis@users.noreply.github.com> Co-authored-by: Shay Bratslavsky <shay@memphis.dev> Co-authored-by: shay23b <shay.b@strech.io>
idanasulin2706
added a commit
that referenced
this pull request
Nov 6, 2022
* update examples + readme * swap . with # in for publish/consume in station & consumer names * update example files * Fix consumerName/Group conversions * type annotation successfully added * updated readme * Use station/consumer internal names for NATS communication * Fix internal name conversion * Update README.md * Update README.md * Updated Types and created consume message anotation * project rebuilt * transporter initialized * Repo updated * updated readme * updated readme * fixed const issue * made further fixes * further fixes * deleted unused import packages@ * deleted and rebuilt the folder * Create Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * readme fixes * readme improvements * add support for generating unique suffix for prod/cons * update readme + js docs * lic change * support for async produce * bugfixes * Headers support for messages sdk (#77) * add prefix $memphis to keys in header * headers support for messages * add a producer example * fix issues * update readme * update examples * fix export issue Co-authored-by: idanasulinStrech <idan@memphis.dev> * add get headers func (#78) * add get headers func * add js docs Co-authored-by: idanasulinStrech <idan@memphis.dev> * added support for schema updates (#79) * added support for schema updates * fixed small bugs * added message validation * fixed bugs + added support for object msg * fixed bugs * small fixes * some more changes * update docs * add build files Co-authored-by: shay23b <shay.b@strech.io> Co-authored-by: idanasulinStrech <idan@memphis.dev> * Update README.md * small bug fix -> should drop listener (#80) Co-authored-by: shay23b <shay.b@strech.io> * update example files * schema validation bugfix * schema validation bugfix - invalid protobuf * added message validation (#81) Co-authored-by: shay23b <shay.b@strech.io> * update build files * added object err handle (#83) * added object err handle * version * build files Co-authored-by: idanasulinStrech <idan@memphis.dev> * Update Jenkinsfile (#85) * Update Jenkinsfile (#86) * access undefined field bugfix * bugfixes Co-authored-by: Or Grinberg <or@memphis.dev> Co-authored-by: taiwo truth <taiwotruth@gmail.com> Co-authored-by: Yaniv Ben Hemo <70286779+yanivbh1@users.noreply.github.com> Co-authored-by: Valera Bronshtein <105710429+valeraBr@users.noreply.github.com> Co-authored-by: Yaniv Ben Hemo <Yaniv@memphis.dev> Co-authored-by: shohamroditimemphis <108217318+shohamroditimemphis@users.noreply.github.com> Co-authored-by: Shay Bratslavsky <shay@memphis.dev> Co-authored-by: shay23b <shay.b@strech.io>
idanasulin2706
added a commit
that referenced
this pull request
Nov 21, 2022
* update examples + readme * swap . with # in for publish/consume in station & consumer names * update example files * Fix consumerName/Group conversions * type annotation successfully added * updated readme * Use station/consumer internal names for NATS communication * Fix internal name conversion * Update README.md * Update README.md * Updated Types and created consume message anotation * project rebuilt * transporter initialized * Repo updated * updated readme * updated readme * fixed const issue * made further fixes * further fixes * deleted unused import packages@ * deleted and rebuilt the folder * Create Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * readme fixes * readme improvements * add support for generating unique suffix for prod/cons * update readme + js docs * lic change * support for async produce * bugfixes * Headers support for messages sdk (#77) * add prefix $memphis to keys in header * headers support for messages * add a producer example * fix issues * update readme * update examples * fix export issue Co-authored-by: idanasulinStrech <idan@memphis.dev> * add get headers func (#78) * add get headers func * add js docs Co-authored-by: idanasulinStrech <idan@memphis.dev> * added support for schema updates (#79) * added support for schema updates * fixed small bugs * added message validation * fixed bugs + added support for object msg * fixed bugs * small fixes * some more changes * update docs * add build files Co-authored-by: shay23b <shay.b@strech.io> Co-authored-by: idanasulinStrech <idan@memphis.dev> * Update README.md * small bug fix -> should drop listener (#80) Co-authored-by: shay23b <shay.b@strech.io> * update example files * schema validation bugfix * schema validation bugfix - invalid protobuf * added message validation (#81) Co-authored-by: shay23b <shay.b@strech.io> * update build files * added object err handle (#83) * added object err handle * version * build files Co-authored-by: idanasulinStrech <idan@memphis.dev> * Update Jenkinsfile (#85) * Update Jenkinsfile (#86) * access undefined field bugfix * bugfixes * Update Jenkinsfile (#90) * license update (#91) * fixing bug throwing an error when schema validation fails * fix msg headers type issue * change file to disk terminology * add memphis error function * update version Co-authored-by: Or Grinberg <or@memphis.dev> Co-authored-by: taiwo truth <taiwotruth@gmail.com> Co-authored-by: Yaniv Ben Hemo <70286779+yanivbh1@users.noreply.github.com> Co-authored-by: Valera Bronshtein <105710429+valeraBr@users.noreply.github.com> Co-authored-by: Yaniv Ben Hemo <Yaniv@memphis.dev> Co-authored-by: shohamroditimemphis <108217318+shohamroditimemphis@users.noreply.github.com> Co-authored-by: Shay Bratslavsky <shay@memphis.dev> Co-authored-by: shay23b <shay.b@strech.io>
idanasulin2706
added a commit
that referenced
this pull request
Dec 4, 2022
* update examples + readme * swap . with # in for publish/consume in station & consumer names * update example files * Fix consumerName/Group conversions * type annotation successfully added * updated readme * Use station/consumer internal names for NATS communication * Fix internal name conversion * Update README.md * Update README.md * Updated Types and created consume message anotation * project rebuilt * transporter initialized * Repo updated * updated readme * updated readme * fixed const issue * made further fixes * further fixes * deleted unused import packages@ * deleted and rebuilt the folder * Create Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * readme fixes * readme improvements * add support for generating unique suffix for prod/cons * update readme + js docs * lic change * support for async produce * bugfixes * Headers support for messages sdk (#77) * add prefix $memphis to keys in header * headers support for messages * add a producer example * fix issues * update readme * update examples * fix export issue Co-authored-by: idanasulinStrech <idan@memphis.dev> * add get headers func (#78) * add get headers func * add js docs Co-authored-by: idanasulinStrech <idan@memphis.dev> * added support for schema updates (#79) * added support for schema updates * fixed small bugs * added message validation * fixed bugs + added support for object msg * fixed bugs * small fixes * some more changes * update docs * add build files Co-authored-by: shay23b <shay.b@strech.io> Co-authored-by: idanasulinStrech <idan@memphis.dev> * Update README.md * small bug fix -> should drop listener (#80) Co-authored-by: shay23b <shay.b@strech.io> * update example files * schema validation bugfix * schema validation bugfix - invalid protobuf * added message validation (#81) Co-authored-by: shay23b <shay.b@strech.io> * update build files * added object err handle (#83) * added object err handle * version * build files Co-authored-by: idanasulinStrech <idan@memphis.dev> * Update Jenkinsfile (#85) * Update Jenkinsfile (#86) * access undefined field bugfix * bugfixes * Update Jenkinsfile (#90) * license update (#91) * fixing bug throwing an error when schema validation fails * fix msg headers type issue * change file to disk terminology * add memphis error function * update version * Update Jenkinsfile (#94) * idempotency support (#97) * Schema Validation Fails Alerts (#95) * Schema Validation Fails Alerts * bug fixes * change subject name * added code block to notification * added type to send notifiaction * build files * Json support schemaverse (#96) * add json support schemaverse * update README file * update _validateJsonSchemaMessage func * seperate logic to func _validateProtobufMessage * readme fixes * fix minor issues * typo * fix issues * fix conflict * remove unnecessary function param Co-authored-by: idanasulinStrech <idan@memphis.dev> * build files * notification update + bug fix (#98) * notification update + bug fix * erase comments * build files * added ack for poison messages (#99) * added ack for poison messages * small fixes * ack message field name fix Co-authored-by: idanasulinStrech <idan@memphis.dev> * build files * version update * json validation fix * json validation bugfixes * Update README.md (#103) Co-authored-by: Or Grinberg <or@memphis.dev> Co-authored-by: taiwo truth <taiwotruth@gmail.com> Co-authored-by: Yaniv Ben Hemo <70286779+yanivbh1@users.noreply.github.com> Co-authored-by: Valera Bronshtein <105710429+valeraBr@users.noreply.github.com> Co-authored-by: Yaniv Ben Hemo <Yaniv@memphis.dev> Co-authored-by: shohamroditimemphis <108217318+shohamroditimemphis@users.noreply.github.com> Co-authored-by: Shay Bratslavsky <shay@memphis.dev> Co-authored-by: shay23b <shay.b@strech.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.