Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install standard Mender Update Modules by default. #1064

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

kacf
Copy link
Member

@kacf kacf commented Aug 20, 2020

The default is changed in order to have a better chance to fix
problems on devices, when the rootfs-image setup us not working, for
example by using the script module.

Changelog: Install standard Mender Update Modules by default. These
are:

  • deb
  • directory
  • docker
  • rpm
  • script
  • single-file
    To disable the automatic installation of these Update Modules, add
    PACKAGECONFIG_remove = "modules" to your mender_%.bbappend file,
    or set PACKAGECONFIG explicitly.

Signed-off-by: Kristian Amlie kristian.amlie@northern.tech

@mender-test-bot
Copy link

Hello 😸 I created a pipeline for you here: Pipeline-180004682

Build Configuration Matrix

Key Value
BASE_BRANCH master
BUILD_BEAGLEBONEBLACK true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/1064/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

The default is changed in order to have a better chance to fix
problems on devices, when the rootfs-image setup us not working, for
example by using the script module.

Changelog: Install standard Mender Update Modules by default. These
are:
* deb
* directory
* docker
* rpm
* script
* single-file
To disable the automatic installation of these Update Modules, add
`PACKAGECONFIG_remove = "modules"` to your `mender_%.bbappend` file,
or set `PACKAGECONFIG` explicitly.

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
@mender-test-bot
Copy link

Hello 😸 I created a pipeline for you here: Pipeline-180036053

Build Configuration Matrix

Key Value
BASE_BRANCH master
BUILD_BEAGLEBONEBLACK true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/1064/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

@mender-test-bot
Copy link

Hello 😸 I created a pipeline for you here: Pipeline-180036356

Build Configuration Matrix

Key Value
BASE_BRANCH master
BUILD_BEAGLEBONEBLACK true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/1064/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

@kacf
Copy link
Member Author

kacf commented Aug 20, 2020

@estenberg, @drewmoseley, @merlin-northern: As discussed in client team meeting.

Copy link
Contributor

@merlin-northern merlin-northern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am all for it!

Copy link
Contributor

@lluiscampos lluiscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think makes much sense to install deb and rpm modules. However from meta-mender point of view, makes sense to just install "whatever modules are supported OOTB", so this PR is okey. Maybe something to consider when adding new modules.

@kacf
Copy link
Member Author

kacf commented Aug 20, 2020

I agree, but it's a separate issue, and if you install the modules today you have the same problem. They do not harm anything by being installed, and take almost no space, so I think it's very low priority to fix.

@kacf kacf merged commit cd19d45 into mendersoftware:master Aug 20, 2020
@kacf kacf deleted the modules_default branch August 20, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants