Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to add YouTube/Vimeo controls via .controls() method? #49

Open
menismu opened this issue Apr 4, 2018 · 0 comments
Open

Impossible to add YouTube/Vimeo controls via .controls() method? #49

menismu opened this issue Apr 4, 2018 · 0 comments

Comments

@menismu
Copy link
Owner

menismu commented Apr 4, 2018

Issue reported: mozilla#451
Reported by: @djvs

@djvs
djvs commented on 22 Jun 2015
This patch was manually added into current stable popcorn-complete.js (to mimic future popcorn-complete releases):

https://github.com/mozilla/popcorn-js/pull/441/files?diff=split

such that Vimeo and YouTube methods all work (Popcorn.youtube, Popcorn.HTMLYoutubeVideoElement, etc.). Player starts and stops correctly on click. However, all video controls are missing, and calling popcorn.controls(true) has no effect, for:

        // "vidid", "vidurl", "elemid" all valid
        var vidurl = "http://player.vimeo.com/video/" + vidid;
        var player = new Popcorn.HTMLVimeoVideoElement("#"+elemid);
        player.src = vidurl;
        player = new Popcorn(player);
        player.controls(true);

Going into inspector and manually adding "controls" attribute to the video element inside the iframe does, however, enable the controls. Shouldn't adding it be a fallback for these wrappers or something similar? My only alternative is DOM manipulation inside the iframe...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant