You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
such that Vimeo and YouTube methods all work (Popcorn.youtube, Popcorn.HTMLYoutubeVideoElement, etc.). Player starts and stops correctly on click. However, all video controls are missing, and calling popcorn.controls(true) has no effect, for:
// "vidid", "vidurl", "elemid" all valid
var vidurl = "http://player.vimeo.com/video/" + vidid;
var player = new Popcorn.HTMLVimeoVideoElement("#"+elemid);
player.src = vidurl;
player = new Popcorn(player);
player.controls(true);
Going into inspector and manually adding "controls" attribute to the video element inside the iframe does, however, enable the controls. Shouldn't adding it be a fallback for these wrappers or something similar? My only alternative is DOM manipulation inside the iframe...
The text was updated successfully, but these errors were encountered:
Issue reported: mozilla#451
Reported by: @djvs
@djvs
djvs commented on 22 Jun 2015
This patch was manually added into current stable popcorn-complete.js (to mimic future popcorn-complete releases):
https://github.com/mozilla/popcorn-js/pull/441/files?diff=split
such that Vimeo and YouTube methods all work (Popcorn.youtube, Popcorn.HTMLYoutubeVideoElement, etc.). Player starts and stops correctly on click. However, all video controls are missing, and calling popcorn.controls(true) has no effect, for:
Going into inspector and manually adding "controls" attribute to the video element inside the iframe does, however, enable the controls. Shouldn't adding it be a fallback for these wrappers or something similar? My only alternative is DOM manipulation inside the iframe...
The text was updated successfully, but these errors were encountered: