Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Big cleanup + small bugfix #180

Closed
wants to merge 2 commits into from
Closed

Big cleanup + small bugfix #180

wants to merge 2 commits into from

Conversation

Alex-D
Copy link
Contributor

@Alex-D Alex-D commented Jul 26, 2014

This is a big cleanup in komanda and icons styles files (see #179)

Be carefull before merge this branch, you need to test each feature tu check if I don't have deleted a usefull line.

I develop on Windows, I have make a little change on the package.json because this not work with the relative path.

This PR should fix #176

@rahatarmanahmed
Copy link
Collaborator

It seems to be mostly okay. The only glaring issue is the github buttons:
new

You're missing background-image: -webkit-gradient( linear, left top, left bottom, from(#d5d6d9), to(#afb0b7)); under .plugin-button.

Also the postinstall script was changed to require bower be installed globally. It's probably best to update the README to illustrate this.

Out of curiosity, what tool did you use to clean this up? (If you did it by hand... wow)

@Alex-D
Copy link
Contributor Author

Alex-D commented Jul 28, 2014

If you did it by hand... wow

By hand, it's the best tool :)

background-image: -webkit-gradient

This is so strange : http://caniuse.com/#search=gradient Chrome (so Blink) does not require -webkit- prefix :/

@rahatarmanahmed
Copy link
Collaborator

Sorry, use the regular gradient. I just meant it was missing a gradient of
any kind.
On Jul 28, 2014 5:07 PM, "Alexandre Demode" notifications@github.com
wrote:

If you did it by hand... wow

By hand, it's the best tool :)

background-image: -webkit-gradient

This is so strange : http://caniuse.com/#search=gradient Chrome (so
Blink) does not require -webkit- prefix :/


Reply to this email directly or view it on GitHub
#180 (comment).

@Alex-D
Copy link
Contributor Author

Alex-D commented Aug 2, 2014

I've fix mistake and I've rebase to make this PR mergeable.

@Alex-D
Copy link
Contributor Author

Alex-D commented Aug 6, 2014

Anyone can check my PR ? I don't want to rebase my PR each 5 minutes :(

So please check it, then I rebase and finaly you merge before merge any other PR. Or you merge by hand and resolve conflicts yourself :/

@tyscorp tyscorp closed this in a6c03a9 Aug 23, 2014
halpin325 pushed a commit to halpin325/komanda that referenced this pull request Aug 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long usernames don't break properly in user list
2 participants