Hwcomposer 1.3 support #21
Conversation
Some Android hwcomposer implementations expect all displays being initialized even if not used. Signed-off-by: Simon Busch <morphis@gravedo.de>
Signed-off-by: Simon Busch <morphis@gravedo.de>
|
Using the new sourceCropf property is required with hwcomposer 1.3 as implementations tend to require it and ignore the other integer based ones. |
|
Please wait a moment with merging this. Follow up commit will fix support for Android < 4.3 |
|
Thank you, will wait. So we won't have to merge siteshwar/android_hardware_qcom_display@95f7ed3 workaround thereafter ? |
|
Right. Changes to the HAL should not be needed with but I didn't looked at this particular case as it's using MAX_DISPLAYS rather than HWC_NUM_DISPLAY_TYPES the other HALs are using. |
|
Should be fine to be merged now. Build and runtime tested with 4.2 and 4.4 based builds. |
| layer->displayFrame = r; | ||
| layer->visibleRegionScreen.numRects = 1; | ||
| layer->visibleRegionScreen.rects = &layer->displayFrame; | ||
| layer->acquireFenceFd = -1; | ||
| layer->releaseFenceFd = -1; | ||
| #if ANDROID_VERSION_MAJOR >= 4 & ANDROID_VERSION_MINOR >= 3 |
There was a problem hiding this comment.
While this will work, maybe using parentheses and the logical (&&) instead of bitwise (&) AND could be better:
#if (ANDROID_VERSION_MAJOR >= 4) && (ANDROID_VERSION_MINOR >= 3)
|
Added some minor comments. Rest looks good. |
The addition of the planeAlpha attribute is one of the bad stories about the HAL compatbility between different Android versions. It was added after 1.2 with jelly bean but not marked as part of 1.2. It doesn't break the ABI. We're adding support for it now depending on the Android version (>= 4.3). Signed-off-by: Simon Busch <morphis@gravedo.de>
|
Sorry for that :) Fixed it and should be correct now. |
No description provided.