Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Independent testing for meta_split.R #31

Closed
wangben718 opened this issue Jun 29, 2022 · 2 comments · Fixed by #77
Closed

Independent testing for meta_split.R #31

wangben718 opened this issue Jun 29, 2022 · 2 comments · Fixed by #77
Assignees
@ginnaram13
Labels
independent test

Comments

@wangben718
Copy link
Collaborator

wangben718 commented Jun 29, 2022 •
edited
Loading

Test plan of meta_split():

Devide meta into groups by "SEX", run meta_dummy() |> meta_split("SEX"). (check whether meta is split and use snapshot testing)
@howardbaik
Copy link

howardbaik commented Aug 23, 2022 •
edited
Loading

I'm confused as to what variable to split by. Do I run meta_dummy() |> meta_split("RACE") or meta_dummy() |> meta_split("SEX") or both?

@wangben718
Copy link
Collaborator Author

Hi @howardbaek , actually either is ok. I have revised the test plan. Sorry for the inconvenience.

@ginnaram13 ginnaram13 linked a pull request Sep 14, 2022 that will close this issue
31 independent testing for meta splitr #77
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ginnaram13 ginnaram13

Labels
independent test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

31 independent testing for meta splitr Merck/metalite
3 participants
@howardbaik @wangben718 @ginnaram13