New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mvp architecture #9

Merged

mercuriete merged 1 commit into master from 8-add-mvp-architecture

Nov 19, 2018

Owner

mercuriete commented Nov 12, 2018

closes add mvp architecture #8
rename package to bpmcalculator (bad refactoring changes all over the place)
implements BaseView and BasePresenter as shown in tutorials
define BPMCalculator view presenter contract
define dependencies in module
Implements presenter and injects BPMCalculatorService
activity is a view and now have presenter injected with dagger and only interacts with it.

mercuriete force-pushed the 8-add-mvp-architecture branch 2 times, most recently from 78c2eb0 to 0ee8261 Compare

November 14, 2018 18:06


          working on #8

b09216a

implementing MVP with dagger and koting
its too hard men
testing CI please squash or ammend

mercuriete force-pushed the 8-add-mvp-architecture branch from 0ee8261 to b09216a Compare

November 14, 2018 20:37

mercuriete merged commit 3be35ff into master

mercuriete deleted the 8-add-mvp-architecture branch

November 19, 2018 20:10

mercuriete mentioned this pull request

Product Backlog #1

Open

37 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment