Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mvp architecture #8

Closed
mercuriete opened this issue Nov 12, 2018 · 0 comments · Fixed by #9
Closed

add mvp architecture #8

mercuriete opened this issue Nov 12, 2018 · 0 comments · Fixed by #9
Labels
enhancement New feature or request

Comments

@mercuriete
Copy link
Owner

As a < type of user >, I want < some goal > so that < some reason >.
Fuking Scrum

I as a product_owner/analyst/developer/tester/user, I want to do MVP so that i can be fancy

OK but now serious

I wanted to decuple the views and the logic, so i read some documentation about it and it seems that MVP is the best option for android.
I saw an example on android architecture-examples that makes use of dagger2 and MVP.

My goal is create a project with dagger2, MVP and kotlin.

The things to archive this goal are.

  • create a contract for the main activity (that now is bpm detector activity)
  • implement view contract in MainActivity
  • implement presenter contract that talks with view and the BPMDetectorService.

Out of main scope, I also wanted to delete an extra button, and tap directly to the label to test if decoupling is good (that i know that it is good).
@mercuriete mercuriete changed the title add MVP architecture add mvp architecture Nov 12, 2018
mercuriete pushed a commit that referenced this issue Nov 12, 2018
working on #8
232e6ce 
implementing MVP with dagger and koting
its too hard men
testing CI please squash or ammend
@mercuriete mercuriete mentioned this issue Nov 12, 2018
Merged
mercuriete pushed a commit that referenced this issue Nov 14, 2018
working on #8
78c2eb0 
implementing MVP with dagger and koting
its too hard men
testing CI please squash or ammend
mercuriete pushed a commit that referenced this issue Nov 14, 2018
working on #8
0ee8261 
implementing MVP with dagger and koting
its too hard men
testing CI please squash or ammend
@mercuriete mercuriete added the enhancement New feature or request label Nov 14, 2018
mercuriete pushed a commit that referenced this issue Nov 14, 2018
working on #8
b09216a 
implementing MVP with dagger and koting
its too hard men
testing CI please squash or ammend
mercuriete added a commit that referenced this issue Nov 19, 2018
@mercuriete
add mvp architecture (#9)
3be35ff 
* closes #8
* rename package to bpmcalculator (bad refactoring changes all over the place)
* implements BaseView and BasePresenter as shown in tutorials
* define BPMCalculator view presenter contract
* define dependencies in module
* Implements presenter and injects BPMCalculatorService
* activity is a view and now have presenter injected with dagger and only interacts with it.
@mercuriete mercuriete mentioned this issue Nov 19, 2018
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add mvp architecture mercuriete/android-musician-tools
1 participant
@mercuriete