Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Inspect Splits Page #1466

Merged
merged 51 commits into from
Nov 4, 2020
Merged

Conversation

isaacfink21
Copy link
Contributor

@isaacfink21 isaacfink21 commented Jul 13, 2020

This PR updates the inspect splits page with several additions, including:

  • A nucleotide/amino acid display
  • Coloring genes by COG, KEGG metabolic categories, or by gene ID
  • Visualization of insertions/deletions
  • Highlight bars for nucleotides

@isaacfink21
Copy link
Contributor Author

isaacfink21 commented Jul 18, 2020

It should be fixed now - sorry about that! I must have committed a broad part of the anvio directory so I'll make sure to commit specific files in the future :)

I also fixed the amino acid sequence to work with genes in the reverse direction and added a button on the sidebar to toggle the nucleotide display.

@meren
Copy link
Member

meren commented Jul 28, 2020

Hey @isaacfink21, in master we are able to click on SNVs to see this panel:

image

But it seems SNVs are no longer 'clickable' :)

@isaacfink21
Copy link
Contributor Author

isaacfink21 commented Jul 28, 2020

Thanks for pointing this out! I had disabled pointer-events on SVG text to prevent the selection of the sequences or x-scale - the first commit above should fix this and has a better implementation :)

@isaacfink21 isaacfink21 merged commit 12b2c11 into merenlab:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants