-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stepwise completeness, module copy number, and a bunch of other useful updates to metabolism #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y in the dictionary
…e this data in the hits_in_modules output mode
…rate for paths with duplicate kos. the problem was that we put the hit counts into a dictionary and used the number of keys as path length, thereby ignoring duplicate kos
…to be split into only their essential components. otherwise we couldn't look up their hit counts in the module dictionary
… as completeness except for modules defined by other modules
…modules that don't have complete paths
… realized it while writing up the documentation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be my last major update to the metabolism code for the next few months. It includes the following updates:
--add-copy-number
is used to add this data to long format output, or to generate additional matrix files with these metricsanvi-compute-metabolic-enrichment
uses pathwise completeness by default, but you can request to use stepwise completeness instead with the new flag--use-stepwise-completeness
anvi-setup-kegg-kofams
has been refactored to better separate download of data from database setup. There are two new flags,--only-download
and--only-database
, for better control of what is done when the-D
flag is used. This is mostly useful for quick testing: now you can download the data once using--only-download
and run the database setup multiple times using--only-database
anvi-setup-kegg-kofams
. It includes BRITE data and modules db v4The metabolism suite of
anvi-self-test
+ documentation have been updated to reflect these new changes. The PR passes the self test. Feel free to check the help pages for descriptions of these new features :)