Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justification for patterns #18

Closed
dminuoso opened this issue Dec 14, 2021 · 1 comment
Closed

Justification for patterns #18

dminuoso opened this issue Dec 14, 2021 · 1 comment

Comments

@dminuoso
Copy link

Hi.

I was wondering, is there a particular reason you look for say core/LogEvent.class rather than log4j/com/LogEvent.class?

https://github.com/mergebase/log4j-detector/blob/master/src/main/java/com/mergebase/log4j/Log4JDetector.java#L21-L26

@juliusmusseau
Copy link
Contributor

The log4j-core artifact typically contains LogEvent.class inside a "core" sub-directory.

Try downloading log4j-core-2.16.0.jar for yourself to see. Rename it to *.zip and then explore its contents. You should see a "LogEvent.class" file inside there inside the ".\org\apache\logging\log4j\core" sub-directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants