You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 1, 2023. It is now read-only.
Due to a change in docker, container names can no longer include an underscore. A legacy name with an underscore leads to an invalid hostname (merll/docker-fabric#14) error that is hard to trace down. I suggest an assertion in the constructor for maps/containers (and/or their configs) that validates names and raises an informative exception.
The text was updated successfully, but these errors were encountered:
Underscores are quite common for variable names in Python and in my opinion should therefore also be valid for container and client configuration names. As the restriction only seems to apply to the host names but not the Docker container names, I have added a method for replacing certain characters for container host names and link alias names. Underscores are replaced with dashes. Similarly, dots are replaced with dashes since they would lead to a strange subdomain syntax. The behavior can be customized by changing the dockermap.map.policy.base.BasePolicy.hostname_replace dictionary.
Due to a change in docker, container names can no longer include an underscore. A legacy name with an underscore leads to an invalid hostname (merll/docker-fabric#14) error that is hard to trace down. I suggest an assertion in the constructor for maps/containers (and/or their configs) that validates names and raises an informative exception.
The text was updated successfully, but these errors were encountered: