Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much blank space at the bottom of user journey #3501

Open
acalvo opened this issue Sep 21, 2022 · 4 comments
Open

Too much blank space at the bottom of user journey #3501

acalvo opened this issue Sep 21, 2022 · 4 comments
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@acalvo
Copy link

acalvo commented Sep 21, 2022

Describe the bug
There is too much blank space at the bottom of a User Journey SVG diagram. See the screenshot below.

To Reproduce
Check or generate any User Journey, for example the one in https://github.com/mermaid-js/mermaid/blob/develop/docs/user-journey.md

Expected behavior
Just like other diagrams, I'd expect it to have a similar padding on the top and on the bottom of the SVG diagram. However, the bottom space is way bigger than the top one (see the screenshot below).

This, added to the standard margin around the image/paragraphs added in any page make a noticeable big space.

Screenshots

Screenshot 2022-09-21 at 15 43 15

Code Sample
https://github.com/mermaid-js/mermaid/blob/develop/docs/user-journey.md

Desktop (please complete the following information):

  • OS: -
  • Browser: -
  • Version: -

Smartphone (please complete the following information):

  • Device: -
  • OS: -
  • Browser: -
  • Version: -

Additional context

@acalvo acalvo added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Sep 21, 2022
@Harini1023
Copy link

hello, @acalvo! I would like to work on this task. Could you please assign it to me.

@acalvo
Copy link
Author

acalvo commented Oct 5, 2022

Hi @Harini1023 . Thanks for volunteering! I have no permissions to assign this issue to anyone - I'm just a random Mermaid user who reported the bug.

I'm sure the project will happily consider PRs, though. See https://github.com/mermaid-js/mermaid/blob/develop/CONTRIBUTING.md

@slorber
Copy link

slorber commented Oct 14, 2022

Note this is particularly a problem for mobile device with small viewport width where the space gets much larger:

CleanShot 2022-10-14 at 16 30 08

Can repro on your own doc: https://mermaid-js.github.io/mermaid/#/user-journey

@alex-titarenko
Copy link
Contributor

Any updates on the fix for this issue?

@jgreywolf jgreywolf added roadmap items to add to roadmap for auto workflow and removed roadmap items to add to roadmap for auto workflow labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

5 participants