Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: configurable travis-ci.com #19

Closed
hutchic opened this issue Jun 28, 2016 · 4 comments
Closed

Feature Request: configurable travis-ci.com #19

hutchic opened this issue Jun 28, 2016 · 4 comments

Comments

@hutchic
Copy link

hutchic commented Jun 28, 2016

Having the ability to override trigger-travis.sh to use travis-ci.com could be beneficial

@mernst
Copy link
Owner

mernst commented Jun 28, 2016

I agree. I have added an optional --pro command-line argument to trigger-travis.sh, in commit cfb166d.

This is untested because I don't have any projects on travis-ci.com. Could you please test my change?

@hutchic
Copy link
Author

hutchic commented Jun 30, 2016

running out the door but I can PR this on Monday if you like:

TRAVIS_URL=travis-ci.org
if [ "$1" = "--pro" ] 
then
  TRAVIS_URL=travis-ci.com
  shift
fi

@mernst
Copy link
Owner

mernst commented Jun 30, 2016

Right, I needed to quote the arguments to eq. Thank you for catching that. Commit 69d7bed adds the quoting. Feel free to PR any further issues that you notice.

Thanks.

@hutchic
Copy link
Author

hutchic commented Jul 5, 2016

LGTM

@hutchic hutchic closed this as completed Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants