-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resuming a game app will sometimes not work #51
Comments
Hi, thanks for the issue! I'll see if I can investigate this when I get a little time. If you are comfortable sharing, knowing what you were trying to suspend might help as well. |
The app is a game, Phoenix Point |
When this happens, if you restart Nyrna does resuming the app work properly? |
1 similar comment
When this happens, if you restart Nyrna does resuming the app work properly? |
Please re-open this issue @Merrit - I have the exact same issue on Windows 10. It seems to happen after suspending the system (i.e. closing the lid) and when the app hasn't been resumed for a few hours. I just force-closed the game that didn't want to resume (and lost all my progress), but I'll make sure to make screenshots and try to restart Nyrna if it happens again. |
@mrrfv Yes, restarting Nyrna would be good. If that fails then also please try running Nyrna as admin and see if that has any effect. I'll look into the possibility of adding additional logging for the issue. 👍 |
@Merrit Managed to reproduce this issue on Windows for 3 apps (Paint, Minecraft launcher, Minecraft). It's as simple as suspending an app and closing the laptop lid (putting it to sleep). Upon opening the lid, Windows will say the app is 'not responding' and Nyrna won't be able to resume it. If Nyrna is restarted, it thinks that the suspended app is resumed. |
@mrrfv Thanks for the info, I think I can now reproduce this issue. I will see if I can do some debugging on it :) |
The current implementation was probably an attempt to reduce resource usage for Windows, however it was poorly done and was causing existing windows to not update their status unless that tile specifically was clicked. Fixes #51
I suspended 3 apps (Discord, Brave mid-sleep, Spotify) on the new Portable build, closed and opened my laptop's lid and Nyrna went crazy - Brave was correctly reported as suspended, but other apps weren't. When I tried to resume Spotify, Nyrna crashed. I don't know what happened there... After restarting Nyrna, it correctly resumes all the apps, so I suppose the issue is somewhere in auto refresh. |
Wow, that's something. Are you able to trigger the issue in any way besides suspending your computer? |
Not sure to be honest. |
The current implementation was probably an attempt to reduce resource usage for Windows, however it was poorly done and was causing existing windows to not update their status unless that tile specifically was clicked. Fixes #51
I presume that Nyrna being suspended itself when you suspend the computer causes its refresh timer to break. This kind of issue is definitely why we have a disclaimer that funny things can happen when suspending a process.. I don't think there is really a way to check for and recover from such an issue. I'd suggest if you are suspending the entire computer to either switch Nyrna to manual refresh, or to close it before suspending the computer. I have definitely cleaned up the code where we update the status of a process, and it is much more reliable now and that specific bug appears to be resolved. Thanks for all the help with troubleshooting and figuring out this issue! 🎉 |
The current implementation was probably an attempt to reduce resource usage for Windows, however it was poorly done and was causing existing windows to not update their status unless that tile specifically was clicked. Fixes #51
The current implementation was probably an attempt to reduce resource usage for Windows, however it was poorly done and was causing existing windows to not update their status unless that tile specifically was clicked. Fixes #51
The current implementation was probably an attempt to reduce resource usage for Windows, however it was poorly done and was causing existing windows to not update their status unless that tile specifically was clicked. Fixes #51
The current implementation was probably an attempt to reduce resource usage for Windows, however it was poorly done and was causing existing windows to not update their status unless that tile specifically was clicked. Fixes #51
Describe the bug
Resuming a game app will not work correctly all the time. But I cannot identify a specific pattern or cause. This only uncommonly happens (maybe once every 20 suspend/resumes?). Not sure. Only clue I have is the log.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Expect app to resume without using Resource Monitor.
Screenshots
If applicable, add screenshots to help explain your problem.
Software (please complete the following information):
Additional context
LOG files (ALL):
2021-08-25 11:40:04.944296
WARNING
Logger: Win32Process
Error getting executable name: 6
EDIT: okay as soon as it happened again I took a look at the log:
2021-08-26 23:03:19.939150
WARNING
Logger: Win32Process
Error getting executable name: 6
I think this executable name error is causing this.
The text was updated successfully, but these errors were encountered: