Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer to peer code review #25

Open
noelfoka opened this issue Aug 1, 2023 · 0 comments
Open

Peer to peer code review #25

noelfoka opened this issue Aug 1, 2023 · 0 comments

Comments

@noelfoka
Copy link

noelfoka commented Aug 1, 2023

Impeccable work.

  • the good practice of javascript ✔️
  • good unit test ✔️
  • good configuration of the webpack ✔️

however, we have a few changes to suggest:

  • Incomplete readme: No authors in the readme file, please adjust it for us to know who is working on this project
  • The navigations in the header are not in the context of the page. Also the some CSS for the buttons can improve the look of the page as there is no stylings on the comments buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant