Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/comments #23

Merged
merged 7 commits into from
Jul 31, 2023
Merged

Feature/comments #23

merged 7 commits into from
Jul 31, 2023

Conversation

hamidazim321
Copy link
Collaborator

In this PR:

  • I have added functions to make a pop up window when clicked on the comment button
  • I have added functions to populate the popup window with data from the API
  • I have added function to allow user to post a comment

mershark
mershark approved these changes Jul 31, 2023
View reviewed changes
Copy link
Owner

@mershark mershark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job working on this task 👏
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

@hamidazim321 hamidazim321 merged commit 1c747f4 into feature/merges Jul 31, 2023
5 checks passed
This was linked to issues Aug 1, 2023
[4pt] -Display Comments pop up with selected item's details - Student B #14
Open
[4pt] - Create feature: add new comment - Student B #8
Open
[3pt] - Display comments for a given item on the Comments pop-up - Student B #11
Open
[3pt] - Add comments counter - Student B #5
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mershark mershark mershark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hamidazim321 @mershark