Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issues #158

Open
bahbah opened this issue Jul 17, 2017 · 3 comments
Open

Security issues #158

bahbah opened this issue Jul 17, 2017 · 3 comments
Labels

Comments

@bahbah
Copy link

bahbah commented Jul 17, 2017

Hi,

I believe these URLs are open

http://[YourMuximux]/secret.txt

Using the value in that txt file, you can view the log:
http://[YourMuximux]/muximux.php?secret=XXXXX&action=log

Or you can write to the log. Not sure what the size limit is here. I guess someone could exploit it and fill up your server with garbage.
http://[YourMuximux]/muximux.php?secret=XXXXX&action=writeLog&msg=Blah

Cheers.

@RafaelSchridi
Copy link

RafaelSchridi commented Aug 6, 2017

Shows an empty page for me.

http://i.imgur.com/IU61cW8.png

@mescon
Copy link
Owner

mescon commented Aug 6, 2017

Hey!

While muximux doesn't contain perfect security by no means, this particular problem is a non-issue as far as I can tell. Can you show a proof of concept?
Also, we encourage all users to always secure their installation with Basic Auth or other means of securing it.

I tried doing what you wrote, but the log file is not written to in this scenario.

Thanks for your report nevertheless.

@d8ahazard
Copy link
Collaborator

FWIW - I've already addressed this in the working codebase I've got local on my machine. Secret.txt is no longer, and the key is stored in the protected config file with other settings.

Just got a few more days on UI work, then I'll have these changes committed to the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants