Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Several PRs were failed under golangci-lint checking process. #623

Closed
Aisuko opened this issue Sep 14, 2023 · 5 comments
Closed

[CI] Several PRs were failed under golangci-lint checking process. #623

Aisuko opened this issue Sep 14, 2023 · 5 comments
Assignees
@AryanSharma9917
Labels
area/ci Continuous integration | Build and release issue/stale Issue has not had any activity for an extended period of time language/go Golang related service-mesh/istio Issues related to Istio

Comments

@Aisuko
Copy link
Member

Aisuko commented Sep 14, 2023

Current Behavior

run golangci-lint
  Running [/home/runner/golangci-lint-1.49.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: istio.Log undefined (type *Istio has no field or method Log) (typecheck)
  Error: istio.Log undefined (type *Istio has no field or method Log) (typecheck)
  Error: istio.Log undefined (type *Istio has no field or method Log) (typecheck)
  Error: istio.Config undefined (type *Istio has no field or method Config) (typecheck)
  Error: istio.Config undefined (type *Istio has no field or method Config) (typecheck)
  Error: hh.StreamErr undefined (type *Istio has no field or method StreamErr) (typecheck)
  Error: hh.StreamInfo undefined (type *Istio has no field or method StreamInfo) (typecheck)
  Error: hh.StreamErr undefined (type *Istio has no field or method StreamErr) (typecheck)
  Error: hh.StreamInfo undefined (type *Istio has no field or method StreamInfo) (typecheck)
  Error: hh.RunSMITest undefined (type *Istio has no field or method RunSMITest) (typecheck)
  Error: hh.StreamErr undefined (type *Istio has no field or method StreamErr) (typecheck)
  Error: hh.StreamInfo undefined (type *Istio has no field or method StreamInfo) (typecheck)
  Error: istio.StreamErr undefined (type *Istio has no field or method StreamErr) (typecheck)
  Error: istio.StreamInfo undefined (type *Istio has no field or method StreamInfo) (typecheck)
  Error: istio.StreamErr undefined (type *Istio has no field or method StreamErr) (typecheck)
  Error: istio.KubeconfigHandler undefined (type *Istio has no field or method KubeconfigHandler) (typecheck)
  Error: istio.KubeconfigHandler undefined (type *Istio has no field or method KubeconfigHandler) (typecheck)
  Error: istio.KubeconfigHandler undefined (type *Istio has no field or method KubeconfigHandler) (typecheck)
  Error: istio.StreamErr undefined (type *Istio has no field or method StreamErr) (typecheck)
  Error: istio.StreamInfo undefined (type *Istio has no field or method StreamInfo) (typecheck)
  Error: istio.StreamInfo undefined (type *Istio has no field or method StreamInfo) (typecheck)
  Error: istio.EventStreamer undefined (type *Istio has no field or method EventStreamer) (typecheck)

Desired Behavior

golangci-lint should be passed.

Implementation

Acceptance Tests

Contributor Guides and Resources
@Aisuko Aisuko added area/ci Continuous integration | Build and release service-mesh/istio Issues related to Istio language/go Golang related labels Sep 14, 2023
@AryanSharma9917
Copy link

Hey @theBeginner86, I would like to work on this issue.

@Aisuko Aisuko mentioned this issue Sep 30, 2023
Merged
1 task
@Aisuko Aisuko self-assigned this Sep 30, 2023
@stale Stale
Copy link

stale bot commented Nov 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 4, 2023
@Aisuko
Copy link
Member Author

Aisuko commented Nov 5, 2023

remove

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Nov 5, 2023
@Aisuko Aisuko assigned AryanSharma9917 and unassigned Aisuko Nov 5, 2023
@stale Stale
Copy link

stale bot commented Dec 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Dec 10, 2023
@stale Stale
Copy link

stale bot commented Dec 20, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AryanSharma9917 AryanSharma9917

Labels
area/ci Continuous integration | Build and release issue/stale Issue has not had any activity for an extended period of time language/go Golang related service-mesh/istio Issues related to Istio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Aisuko @AryanSharma9917