Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshery-linkerd needs to change the way which manages the Linkerd2 life-cycle to more native with Linkerd2 #67

Closed
Aisuko opened this issue Jun 13, 2020 · 0 comments · Fixed by #99
Assignees
Labels
kind/enhancement Improvement in current feature

Comments

@Aisuko
Copy link
Member

Aisuko commented Jun 13, 2020

Enhancement Description

This may difficult and complex we need to change the main logistic of the Meshery-linkerd and this is the main feature of this adapter.

Current logistic:

  • Every one hour the adapter needs to go to the Github release API to check the newest version of Linkerd2 CLI and download the CLI into the local folder(Sometimes download process was closed but did not with an except, this may cause the deploy process was killed by os without the reason.)

The desired logistic please see below:

  • Using the pre-check while every time the deploy event was triggered
    • Pre-check the cluster status and confirm the cluster can handler linkerd2
      • If there the LInkerd2 was deployed provide, update the Linkerd2 deployments under the native way
      • ELSE deploy the Linkerd2 by native way
      • Return the state of the deployments

Related Challenges
A brief description of what the problem is. (e.g. I need to be able to...)

There needs to get deeper into Linkerd2's original project. (So should lock the version of the dependent package)


[Optional] Alternatives
A brief description of any alternative solutions or features you've considered.

But there is a disadvantage to these two approaches above, neither of then can do a pre-check. In fact, we should follow the official deploy approach to let the deploy process more smooth and do not let the struggling problems happen

[Optional] Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant