Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Singapore Region #3165

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Add Singapore Region #3165

merged 3 commits into from
Feb 9, 2024

Conversation

ndoo
Copy link
Contributor

@ndoo ndoo commented Feb 2, 2024

Add 923MHz band for Singapore.

Regulatory reference: https://www.imda.gov.sg/-/media/imda/files/regulation-licensing-and-consultations/ict-standards/telecommunication-standards/radio-comms/imdatssrd.pdf band 30d.

Fixes #3159.

Build-tested and uploaded to TTGO T-Beam Supreme. Not functionality tested due to meshtastic python CLI config validation throwing "lora.region does not have an enum called SG_923, so you can not set it.".

@CLAassistant
Copy link

CLAassistant commented Feb 2, 2024

CLA assistant check
All committers have signed the CLA.

src/mesh/RadioInterface.cpp Outdated Show resolved Hide resolved
src/mesh/RadioInterface.cpp Outdated Show resolved Hide resolved
@andrekir
Copy link
Member

andrekir commented Feb 2, 2024

there was a previous discussion in #2695

@andrekir andrekir added the requires-protos A change in device that requires changes to protobufs label Feb 2, 2024
@ndoo ndoo requested a review from caveman99 February 4, 2024 14:47
@ndoo
Copy link
Contributor Author

ndoo commented Feb 5, 2024

Apologies for the new commit but fixing the incorrect author name and email metadata in the previous one.

@thebentern thebentern merged commit 74b90d3 into meshtastic:master Feb 9, 2024
60 checks passed
thebentern added a commit to meshtastic/artifacts that referenced this pull request Feb 9, 2024
mverch67 pushed a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-protos A change in device that requires changes to protobufs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SG Region for Lora Radio Configuration
6 participants