Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singapore bands #2695

Closed
wants to merge 2 commits into from

Conversation

crystalfox2
Copy link

Hi,

Adding Singapore band for 920-925 MHz and 433.05-434.79 MHz.

Hope this can be approved.

Thanks.

ps: first time contributing, let me know if i missed out anything. Thanks again

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2023

CLA assistant check
All committers have signed the CLA.

@caveman99
Copy link
Member

Could you point me to specific documentation where a 433 MHz ISM allocation is available in Singapore? Even if it is available you can simply use UA_433. Also the 920-925 MHz band is the same as AS923 already included in the firmware as 'TW'.

@crystalfox2
Copy link
Author

crystalfox2 commented Aug 9, 2023

@andrekir
Copy link
Member

andrekir commented Aug 9, 2023

LoRa Alliance can be used as a general guideline but you should really look into region specific regulations.

IMDA TS SRD Issue 1 Revision 3, April 2023 [Table 1, Item 29, p. 15]

For LoRa Singapore has 866-869MHz with no Duty Cycle and 500mW EIRP (27dBm).

@crystalfox2
Copy link
Author

Hi Andre & All,

Thanks for the pointers.

As per the doc, can we summarized the frequencies as below?

  1. 433.05 – 434.79 MHz, Duty Cycle 10%, 10mW EIRP (10dBm). [Table 1, Item 26a, p. 14]
  2. 866 - 869 MHz, No Duty Cycle, 500mW EIRP (27dBm). [Table 1, Item 29, p. 15]
  3. 917 - 925 Mhz, Duty Cycle 10%, 500mW EIRP (27dBm). [Table 1, Item 30b, p. 15]

Means we only need to add as item 2 & 3? and for item 1 can use any existing EU433?

Some NOOB question

  1. Can we update a commit branch that has been pushed and a pull request been created? I tried to search but not getting clear answer for this.
  2. I noticed that config.pb.h need to add for newly created 'region' (enum), at least for a successful compile. But is located under "generated" folder. Do we need to add in the changes for this file as well for the pull request?

Thanks,
Regards,
Vince

@andrekir
Copy link
Member

one single definition per region is preferred (when unique). adding every LoRa frequency band is confusing.

866-869MHz seems ideal, but make sure to do your own research and confirm this is accurate. ultimately you are responsible for adhering to your local laws, rules and regulations.

1. Can we update a commit branch that has been pushed and a pull request been created? I tried to search but not getting clear answer for this.

commits to your add-singapore-band branch will be added here

2. I noticed that config.pb.h need to add for newly created 'region' (enum), at least for a successful compile. But is located under "generated" folder. Do we need to add in the changes for this file as well for the pull request?

no changes are needed in the generated folder

@crystalfox2
Copy link
Author

Hi Andre,

Yes, it kind of confusing, let me try to write to the relevant party to see i can get any confirmation for this.
Will try again once i have more details.

Regards

@andrekir andrekir mentioned this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants