Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Position always center Melbourne in the Web View #86

Closed
Dtrieb opened this issue Feb 12, 2023 · 4 comments
Closed

BUG: Position always center Melbourne in the Web View #86

Dtrieb opened this issue Feb 12, 2023 · 4 comments

Comments

@Dtrieb
Copy link

Dtrieb commented Feb 12, 2023

Reopen, because new Version have the same problem.

Originally posted by @Dtrieb in #56 (comment)

@Dtrieb Dtrieb changed the title Reopen, because new Version have the same problem. BUG: Position always center Melbourne in the Web View Feb 12, 2023
@sachaw
Copy link
Member

sachaw commented Feb 16, 2023

Do any of your nodes actually have a position fix?
as the map will center on your nodes, but only if they have a position

@karamo
Copy link

karamo commented Mar 11, 2023

In our mesh (≈20 Nodes) - Web-version d1628e3
• all nodes have a position.
• some nodes with position are not displayed in the map. (? FW 2.1.0 ?)
• center to our nodes only with the dashed box top right.

@micheljung
Copy link
Contributor

My node also has a position and is visible on the map, however, it starts in Melbourne. Clicking the dashed box in the top right throws an error in the browser console:

dex-7e029ddc.js:703 Uncaught Error: coordinates must be an array of two or more positions
    at q$ (index-7e029ddc.js:703:35905)
    at s (index-7e029ddc.js:703:37560)
    at onClick (index-7e029ddc.js:703:38176)
    at Object.q9 (index-7e029ddc.js:37:9864)
    at Z9 (index-7e029ddc.js:37:10018)
    at K9 (index-7e029ddc.js:37:10075)
    at d2 (index-7e029ddc.js:37:31482)
    at NS (index-7e029ddc.js:37:31899)
    at index-7e029ddc.js:37:36812
    at ex (index-7e029ddc.js:40:36943)

@micheljung
Copy link
Contributor

micheljung commented Apr 18, 2023

@sachaw I couldn't find where the map was supposed to zoom to the selected nodes but I fixed it. See PR.

micheljung added a commit to zso-pfhr/meshtastic-web that referenced this issue Apr 18, 2023
Before, camera repositioning only worked when there were at least two nodes,
even though the code was meant to handle single nodes as well.

This is related to meshtastic#86 but doesn't fix it.
micheljung added a commit to zso-pfhr/meshtastic-web that referenced this issue Apr 18, 2023
@sachaw sachaw closed this as completed in 90fd35e Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants