Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform_tag is wrong in 32-bit builds on 64-bit Linux kernels #123

Closed
mkoeppe opened this issue Aug 1, 2022 · 2 comments · Fixed by #126
Closed

platform_tag is wrong in 32-bit builds on 64-bit Linux kernels #123

mkoeppe opened this issue Aug 1, 2022 · 2 comments · Fixed by #126
Labels
bug Something isn't working

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 1, 2022

meson-python 0.8.0 creates a wheel named scipy-1.9.0rc3-cp310-cp310-linux_x86_64.whl when run on an i386 Docker image, for example on ubuntu-bionic-i386 (see https://github.com/mkoeppe/sage/runs/7599750782).

Ref: https://trac.sagemath.org/ticket/34081#comment:47
@mkoeppe mkoeppe mentioned this issue Aug 1, 2022
Closed
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 1, 2022

This will need code just like https://github.com/pypa/wheel/blob/main/src/wheel/bdist_wheel.py#L279

@rgommers rgommers added the bug Something isn't working label Aug 1, 2022
@mkoeppe mkoeppe mentioned this issue Aug 2, 2022
Merged
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2022

This is now #126.

Of course, a better fix would take this information from meson, which is building for the correct platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Project.platform_tag: Handle the case of 32bit Python on x86_64 mkoeppe/meson-python
2 participants
@rgommers @mkoeppe