Logging of environment variables in testlog.txt

[fiesh]

I just happened to realize that all our private ssh keys for deployment are logged in testlog.txt :)

Given that passing private keys via environment variables to the CI/CD system is the de facto standard (at least with Gitlab), I think this is a bit of a security hazard. Of course one can selectively unset all relevant variables before the test run, but that's a fragile process in itself when variables are changed or added.

Therefore I suggest that logging environment variables to testlog.txt and testlog.json should only happen when explicitly enabled via command line.

[fphammerle]

workaround until fixed:

replace meson test with env --ignore-environment PATH="$PATH" meson test

[michaelcadilhac]

Got made by this, with one private key leaking in benchmark logs that were stored to test for performance regression. That's a very silly default.