-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds an upload artifacts command to konvoy image builder #214
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 27cd289 |
f6413b1
to
e645bcf
Compare
Please add related target in |
for next iteration: Should we think about combining all artifacts into a single versioned tar if we need to provide all three type of artifacts (rpms, pip packages, images) all the time? This could prevent version mismatching between Edit: Need to take care of OS specific artifacts Vs OS independent artifacts |
|
||
func init() { | ||
fs := artifactsCmd.Flags() | ||
fs.StringVar(&artifactsFlags.Inventory, "inventory-file", "inventory.yaml", "an ansible inventory defining your infrastructure") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add shorthands notations to all commands. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably be addressed in a refactor for all of the subcommands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are following kubectl conventions, it would be good to follow those when we refactoring flags.
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-cli/kubectl-conventions.md#flag-conventions
ansible/provision.yaml
Outdated
@@ -29,7 +29,6 @@ | |||
- include_vars: vars/flatcar/flatcar.yaml | |||
when: ansible_os_family == "Flatcar" | |||
roles: | |||
- role: offline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should actually keep this here. In the case where the user is trying to build an AMI with the offline bundles present
e645bcf
to
d648476
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is going to be a very useful feature.
Co-authored-by: John Baker <jbaker@d2iq.com>
942ff76
to
27cd289
Compare
What problem does this PR solve?:
Creates an
upload artifacts
command to upload artifacts to hosts specified in an inventory file.Which issue(s) does this PR fix?:
https://jira.d2iq.com/browse/D2IQ-83933
Special notes for your reviewer:
I ran the command like so:
I used previous existing terraform scripts to bring up centos7 hosts.
Does this PR introduce a user-facing change?: