Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ansible): allow rsa public keys #271

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Conversation

jkoelker
Copy link
Contributor

@jkoelker jkoelker commented Mar 24, 2022

What problem does this PR solve?:

Looks like we do need both the Host and PublicKey options to enable ssh in ansible from the newer openssh version. (Found this while building an image from main with the wrapper).

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@github-actions github-actions bot added the fix label Mar 24, 2022
@jkoelker jkoelker requested a review from a team March 24, 2022 07:16
@jkoelker jkoelker self-assigned this Mar 24, 2022
@jkoelker jkoelker added the bug Something isn't working label Mar 24, 2022
@github-actions github-actions bot added fix and removed fix labels Mar 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2022

File Coverage
All files 15%
pkg/ansible/runner.go 0%
pkg/app/artifacts.go 0%
pkg/app/build.go 1%
pkg/app/config.go 50%
pkg/app/errors.go 0%
pkg/app/provision.go 0%
pkg/app/root.go 0%
pkg/app/validate.go 0%
pkg/appansible/io.go 0%
pkg/appansible/playbook.go 0%
pkg/azure/azure.go 0%
pkg/logging/logger.go 0%
pkg/packer/manifest.go 0%
pkg/packer/packer.go 0%
pkg/stringutil/rand.go 0%
pkg/version/info.go 8%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against d51f1df

@jkoelker
Copy link
Contributor Author

jkoelker commented Mar 24, 2022

So because the devkit is debian, and the prod image is apline we have a split in what ssh options are allowed ;(. I know originally the devkit was also alpine, but it got switched before opensourcing it due to bash vs sh-isms.

What would the feeling be to switch the devkit back to alpine and just make sure to install bash and set it as the default shell? This will make sure we are using the same base platform that the wrapper is, just with go and all the extra tools installed.

@jkoelker jkoelker marked this pull request as draft March 24, 2022 07:39
@@ -4,19 +4,18 @@ FROM golangci/golangci-lint:v1.44.2-alpine as golangci-lint
FROM goreleaser/goreleaser:v1.7.0 as goreleaser
FROM docker:20.10 as docker

FROM golang:1.17.8 as builder
FROM golang:1.17.8-alpine3.15 as builder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES

@jkoelker
Copy link
Contributor Author

@jkoelker jkoelker marked this pull request as ready for review March 24, 2022 18:57
Copy link
Collaborator

@faiq faiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOU ROCK

@@ -102,7 +102,7 @@ RUN apk add --no-cache \

RUN curl -fsSL --output /tmp/goss.install https://goss.rocks/install \
&& GOSS_VER=v0.3.16 GOSS_DST=/usr/local/bin bash /tmp/goss.install \
&& rm /tmp/goss.insall
&& rm /tmp/goss.install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsie doodle! Thanks for catching!

@faiq faiq merged commit 291e922 into mesosphere:main Mar 24, 2022
@jkoelker jkoelker deleted the jk/ssh_pubkey branch March 24, 2022 20:41
@AndrewBabbitt97 AndrewBabbitt97 mentioned this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants