-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ansible): allow rsa public keys #271
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against d51f1df |
So because the devkit is debian, and the prod image is apline we have a split in what ssh options are allowed ;(. I know originally the devkit was also alpine, but it got switched before opensourcing it due to What would the feeling be to switch the devkit back to alpine and just make sure to install bash and set it as the default shell? This will make sure we are using the same base platform that the wrapper is, just with go and all the extra tools installed. |
@@ -4,19 +4,18 @@ FROM golangci/golangci-lint:v1.44.2-alpine as golangci-lint | |||
FROM goreleaser/goreleaser:v1.7.0 as goreleaser | |||
FROM docker:20.10 as docker | |||
|
|||
FROM golang:1.17.8 as builder | |||
FROM golang:1.17.8-alpine3.15 as builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOU ROCK
@@ -102,7 +102,7 @@ RUN apk add --no-cache \ | |||
|
|||
RUN curl -fsSL --output /tmp/goss.install https://goss.rocks/install \ | |||
&& GOSS_VER=v0.3.16 GOSS_DST=/usr/local/bin bash /tmp/goss.install \ | |||
&& rm /tmp/goss.insall | |||
&& rm /tmp/goss.install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoopsie doodle! Thanks for catching!
What problem does this PR solve?:
Looks like we do need both the Host and PublicKey options to enable ssh in ansible from the newer openssh version. (Found this while building an image from main with the wrapper).
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: