feat: do not copy stdin and set tty to false #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the instruction to copy the stdin in the docker wrapper and set tty to true is some cases. We don't need that since we don't expect KIB to read from stdin.
faiq
reviewed
Mar 20, 2023
| cmd := exec.Command( | ||
| "docker", "run", | ||
| "--interactive", | ||
| "--tty="+strconv.FormatBool(r.tty), | ||
| "--tty=false", |
There was a problem hiding this comment.
should we remove this flag in its entirety?
There was a problem hiding this comment.
it is default... but maybe it makes sense to be explicit.
faiq
approved these changes
Mar 20, 2023
faiq
changed the title
fatz
approved these changes
Mar 21, 2023
|
@faiq shall we plan a backport or better leave it to upcoming versions? |
|
I don’t think it needs a backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
This commit removes the instruction to copy the stdin in the docker wrapper and set tty to true is some cases. We don't need that since we don't expect KIB to read from stdin.
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: