Skip to content
This repository has been archived by the owner on Dec 5, 2017. It is now read-only.

host_port_endpoints is deprecated #785

Closed
jdef opened this issue Feb 15, 2016 · 3 comments
Closed

host_port_endpoints is deprecated #785

jdef opened this issue Feb 15, 2016 · 3 comments

Comments

@jdef
Copy link

jdef commented Feb 15, 2016

Flags should be using - delimiters instead of _.

Also the controller-manager uses this flag to determine endpoint generation, but the scheduler does NOT use this flag to determine the default port mapping strategy. There's a disconnect here.

xref kubernetes/kubernetes#21276

@jdef
Copy link
Author

jdef commented Feb 15, 2016

also, wondering if the kubelet-executor should also have this flag, to control (at least) the func in executor/registry that preserves container ports across pod updates -- there's no need for this code to execute if we're doing doing any kind of dynamic port assignment.

@jdef jdef added LGTM tracking and removed WIP labels Feb 16, 2016
@jdef
Copy link
Author

jdef commented Feb 16, 2016

decided against passing the flag to the kubelet; we'll stay conservative for now, blocking any changes to pod container network configuration once it's launched.

@jdef
Copy link
Author

jdef commented Feb 20, 2016

cherry-picked into v0.7.3, removing cherry-pick label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant