Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong dependency property name #5

Open
kaamil1984 opened this issue May 9, 2020 · 0 comments
Open

Wrong dependency property name #5

kaamil1984 opened this issue May 9, 2020 · 0 comments

Comments

@kaamil1984
Copy link

kaamil1984 commented May 9, 2020

Thanks for pretty gauge library!

I found little bug.

I tried to create a style, that contains MajorTickSize property and... I got an error, because there is no "MajorTickSize" dependency property, but I had no problem with "MinorTickSize".

Problem is here I guess:

DependencyProperty.Register("MajorTickRectSize", typeof(Size), typeof(CircularGaugeControl),

(MajorTickRectSize instead of MajorTickSize).

In the future I would suggest something like this:

nameof(MajorTickColor)

instead of

"MajorTickColor"

and this will be refactor-proof :)

Or maybe even change IntelliSense template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant