Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monitor-switch] - "-l" flag is defined twice (--list & --left) #5

Closed
ZereoX opened this issue Jan 22, 2022 · 2 comments
Closed

[monitor-switch] - "-l" flag is defined twice (--list & --left) #5

ZereoX opened this issue Jan 22, 2022 · 2 comments
Assignees
Labels

Comments

@ZereoX
Copy link

ZereoX commented Jan 22, 2022

Hi,

Would just like to mention that the "-l" flag is defined twice but only applicable for "--list". Changing the flag to anything else should resolve the issue "-ls" for example.

-l|--list) list=1 ;;

-l|--left ) enable=( "${monitors[0]}" );;

Thanks for the script. Has been super useful to make use of VariableRefresh on X11 by disabling the secondary monitor.

@MestreLion
Copy link
Owner

Wow, that's an embarrassing overlook! Thank you very much for spotting!

So, as a fix, what do you think about -L for left (and also changing right to -R for consistency)?

@MestreLion MestreLion added the Bug label Jan 23, 2022
@MestreLion MestreLion self-assigned this Jan 23, 2022
@ZereoX
Copy link
Author

ZereoX commented Jan 23, 2022

Wow, that's an embarrassing overlook! Thank you very much for spotting!

So, as a fix, what do you think about -L for left (and also changing right to -R for consistency)?

Yeah, that seems completely reasonable with me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants