Validate required writeback form fields

metabase · Jun 16, 2022 · 05e61d7 · 05e61d7
1 parent 804ee0c
commit 05e61d7
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/frontend/src/metabase/writeback/containers/WritebackForm.tsx b/frontend/src/metabase/writeback/containers/WritebackForm.tsx
@@ -3,6 +3,7 @@ import { t } from "ttag";
 
 import Form from "metabase/containers/Form";
 
+import validate from "metabase/lib/validate";
 import { TYPE } from "metabase/lib/types";
 
 import Field from "metabase-lib/lib/metadata/Field";
@@ -56,6 +57,18 @@ function getFieldTypeProps(field: Field) {
   return { type: "input" };
 }
 
+function getFieldValidationProp(field: Field) {
+  let validator = validate as any;
+
+  if (field.database_required) {
+    validator = validator.required();
+  }
+
+  return {
+    validate: validator,
+  };
+}
+
 function WritebackForm({ table, row, onSubmit, ...props }: WritebackFormProps) {
   const editableFields = useMemo(() => table.fields.filter(isEditableField), [
     table,
@@ -78,6 +91,7 @@ function WritebackForm({ table, row, onSubmit, ...props }: WritebackFormProps) {
           description: field.description,
           initial: initialValue,
           ...getFieldTypeProps(field),
+          ...getFieldValidationProp(field),
         };
       }),
     };