E2E repro for "Fix issue with root collection in QuestionPicker" (#44318

)

e2e/support/cypress_sample_instance_data.js

@@ -48,6 +48,11 @@ export const NO_DATA_PERSONAL_COLLECTION_ID = _.findWhere(
   { name: "No Data Tableton's Personal Collection" },
 ).id;
 
+export const NO_COLLECTION_PERSONAL_COLLECTION_ID = _.findWhere(
+  SAMPLE_INSTANCE_DATA.collections,
+  { name: "No Collection Tableton's Personal Collection" },
+).id;
+
 export const FIRST_COLLECTION_ID = _.findWhere(
   SAMPLE_INSTANCE_DATA.collections,
   { name: "First collection" },

e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js

@@ -1,5 +1,6 @@
 import { WRITABLE_DB_ID, SAMPLE_DB_ID } from "e2e/support/cypress_data";
 import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
+import { NO_COLLECTION_PERSONAL_COLLECTION_ID } from "e2e/support/cypress_sample_instance_data";
 import {
   restore,
   visualize,
@@ -27,6 +28,8 @@ import {
   createQuestion,
   saveQuestion,
   echartsContainer,
+  newButton,
+  appBar,
 } from "e2e/support/helpers";
 
 const { ORDERS, ORDERS_ID, PRODUCTS } = SAMPLE_DATABASE;
@@ -684,3 +687,34 @@ describe("issue 10493", () => {
     });
   });
 });
+
+describe("issue 44071", () => {
+  const questionDetails = {
+    name: "Test",
+    query: { "source-table": ORDERS_ID },
+    collection_id: NO_COLLECTION_PERSONAL_COLLECTION_ID,
+  };
+
+  beforeEach(() => {
+    restore();
+    cy.signIn("nocollection");
+    createQuestion(questionDetails);
+  });
+
+  it("should be able to save questions based on another questions without collection access (metabase#44071)", () => {
+    cy.visit("/");
+    newButton("Question").click();
+    entityPickerModal().within(() => {
+      entityPickerModalTab("Saved questions").click();
+      cy.findByText(/Personal Collection/).click();
+      cy.findByText(questionDetails.name).click();
+    });
+    getNotebookStep("data")
+      .findByText(questionDetails.name)
+      .should("be.visible");
+    saveQuestion();
+    appBar()
+      .findByText(/Personal Collection/)
+      .should("be.visible");
+  });
+});