Fix unused underscored not caught by ESLint (#25748)

metabase · Oct 3, 2022 · 2083161 · 2083161
1 parent e3fef01
commit 2083161
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 5 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -5,7 +5,7 @@
     "no-var": 1,
     "no-unused-vars": [
       1,
-      { "vars": "all", "args": "none", "varsIgnorePattern": "^_" }
+      { "vars": "all", "args": "none", "varsIgnorePattern": "^_.+" }
     ],
     "no-empty": [1, { "allowEmptyCatch": true }],
     "curly": [1, "all"],

diff --git a/frontend/src/metabase/components/SelectList/BaseSelectListItem.jsx b/frontend/src/metabase/components/SelectList/BaseSelectListItem.jsx
@@ -1,6 +1,5 @@
 import React from "react";
 import PropTypes from "prop-types";
-import _ from "underscore";
 
 import { useScrollOnMount } from "metabase/hooks/use-scroll-on-mount";
 

diff --git a/frontend/src/metabase/core/components/AccordionList/AccordionListCell.jsx b/frontend/src/metabase/core/components/AccordionList/AccordionListCell.jsx
@@ -3,7 +3,6 @@
 import React from "react";
 
 import cx from "classnames";
-import _ from "underscore";
 import { color } from "metabase/lib/colors";
 
 import Icon from "metabase/components/Icon";

diff --git a/frontend/src/metabase/query_builder/components/DataSelector/saved-question-picker/utils.js b/frontend/src/metabase/query_builder/components/DataSelector/saved-question-picker/utils.js
@@ -1,5 +1,3 @@
-import _ from "underscore";
-
 export const findCollectionByName = (collections, name) => {
   if (!collections || collections.length === 0) {
     return null;