Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie chart sometimes does not show total #12506

Closed
tatusis opened this issue May 12, 2020 · 6 comments
Closed

Pie chart sometimes does not show total #12506

tatusis opened this issue May 12, 2020 · 6 comments
Assignees
Labels
Priority:P2 Average run of the mill bug Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts.
Milestone

Comments

@tatusis
Copy link

tatusis commented May 12, 2020

Describe the bug
Pie chart sometimes does not show total.

Expected behavior
pie chart sometimes does not show total, neither in the individual question nor when the question is on a panel. The total appears when you pass the mouse over the chart.

Screenshots
pie_chart

Information about your Metabase Installation:
{
"browser-info": {
"language": "pt-BR",
"platform": "Win32",
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0",
"vendor": ""
},
"system-info": {
"file.encoding": "Cp1252",
"java.runtime.name": "Java(TM) SE Runtime Environment",
"java.runtime.version": "1.8.0_241-b07",
"java.vendor": "Oracle Corporation",
"java.vendor.url": "http://java.oracle.com/",
"java.version": "1.8.0_241",
"java.vm.name": "Java HotSpot(TM) 64-Bit Server VM",
"java.vm.version": "25.241-b07",
"os.name": "Windows Server 2012 R2",
"os.version": "6.3",
"user.language": "en",
"user.timezone": "America/Sao_Paulo"
},
"metabase-info": {
"databases": [
"h2",
"oracle",
"postgres"
],
"hosting-env": "unknown",
"application-database": "postgres",
"application-database-details": {
"database": {
"name": "PostgreSQL",
"version": "9.6.14"
},
"jdbc-driver": {
"name": "PostgreSQL JDBC Driver",
"version": "42.2.8"
}
},
"run-mode": "prod",
"version": {
"tag": "v0.35.3",
"date": "2020-04-21",
"branch": "release-0.35.x",
"hash": "1d424cb"
},
"settings": {
"report-timezone": null
}
}
}

Severity
The error directly impacts the user experience. It is necessary to pass the mouse over the chart for it to work correctly.

@tatusis tatusis added .Needs Triage Type:Bug Product defects labels May 12, 2020
@tatusis tatusis changed the title Pie chart does not show total Pie chart sometimes does not show total May 12, 2020
@bjoernhasse
Copy link

Hi @tatusis, I think this has something to do with the size of the pie chart.
Try to make the chart wider. This should display the total sum.

@flamber
Copy link
Contributor

flamber commented May 12, 2020

Hi @tatusis
Can you provide steps to reproduce? Preferably with Sample Dataset or static SQL

@tatusis
Copy link
Author

tatusis commented May 12, 2020

Hi @flamber

Follow the steps below:

  • Select the products table from the sample dataset
  • Summarize the number of lines grouped by categories

pie_chart_example

@bjoernhasse , I believe it is not the size of the chart, because the error does not appear only in the panel.

Thank you.

@tatusis
Copy link
Author

tatusis commented May 12, 2020

Hi
I believe that this error below appears when the total is not displayed. Even when the total appears, it takes a long time. It should be fast, at least in the sample dataset. When the total appears this error below is not displayed.

When the error appears, it is usually on the first load. Later reloads do not present the error.

error

@flamber
Copy link
Contributor

flamber commented May 12, 2020

Steps to reproduce

  1. Simple question > Sample Dataset > Products
  2. Summarize Count by Category
  3. Change visualization to Pie chart
  4. Save question
  5. Refresh browser (or go to the question from a collection/search), shows no total
  6. Move the mouse over the pie and away again, will make it show the total

Same behavior on the dashboard, so giving P2, since it makes Pie viz not very good - specially for non-interactive dashboards.
I don't know if the error is specific to this or something general about Pie:
Invariant Violation: Minified React error #44; visit ...

EDIT: It seems like it's a race-condition. Sometimes it shows, sometimes it don't. It feels better on master now (June 27th)

@alxnddr
Copy link
Member

alxnddr commented Mar 31, 2021

Fixed in #15405

This was referenced May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P2 Average run of the mill bug Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts.
Projects
None yet
Development

No branches or pull requests

5 participants