Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Off Flow #14802

Closed
2 tasks done
rlotun opened this issue Feb 13, 2021 · 1 comment
Closed
2 tasks done

Migrate Off Flow #14802

rlotun opened this issue Feb 13, 2021 · 1 comment
Assignees
@ariya
Labels
.Epic Feature Implementation or Project Type:Tech Debt or Refactoring
Projects
39 and 38.x Planning Board
Milestone
0.39

Comments

@rlotun
Copy link
Contributor

rlotun commented Feb 13, 2021 •
edited by ariya

Since we only partially use flow, the type annotations get in the way vs actually providing much value. We've decided to remove the type annotations and remove our dependence on Flow.

Implementation Plan

ETA: 03/07/2021 (basically by the time 39 lands)

Milestone 1

  • Remove type annotations
  • Remove flow dependency

How to Test This Feature Out

This should Just Work
@rlotun rlotun added Type:Tech Debt or Refactoring .Epic Feature Implementation or Project labels Feb 13, 2021
@rlotun rlotun added this to On Deck Projects in 39 and 38.x Planning Board Feb 13, 2021
@rlotun rlotun mentioned this issue Feb 13, 2021
Merged
@ariya ariya moved this from On Deck Projects to In Progress Projects in 39 and 38.x Planning Board Mar 4, 2021
@rlotun rlotun added this to the 0.39 milestone Mar 5, 2021
@camsaul
Copy link
Member

camsaul commented Mar 9, 2021

Implemented in #14236

@camsaul camsaul closed this as completed Mar 9, 2021
@rlotun rlotun moved this from In Progress Projects to Closed Issues and PRs in 39 and 38.x Planning Board Mar 9, 2021
@ariya ariya mentioned this issue Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariya ariya

Labels
.Epic Feature Implementation or Project Type:Tech Debt or Refactoring
Projects
No open projects
39 and 38.x Planning Board
Closed Issues and PRs
Milestone
0.39
Development

No branches or pull requests
3 participants
@ariya @rlotun @camsaul