Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semi-valid JavaScript code in metabase-lib #17385

Closed
ariya opened this issue Aug 9, 2021 · 1 comment
Closed

Semi-valid JavaScript code in metabase-lib #17385

ariya opened this issue Aug 9, 2021 · 1 comment
Assignees
@ariya
Labels
Type:Tech Debt or Refactoring

Comments

@ariya
Copy link
Contributor

ariya commented Aug 9, 2021

The code in frontend/src/metabase-lib/lib is not 100% valid JavaScript code due to many left-over Flow types (see #14802). This makes it hard to refactor (e.g. symbol renaming) and to edit (e.g. code completion) and to debug.
@ariya ariya self-assigned this Aug 9, 2021
@ariya ariya added the Type:Tech Debt or Refactoring label Aug 9, 2021
@ariya
Copy link
Contributor Author

ariya commented Apr 19, 2022

Superseded by #21689.

@ariya ariya closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariya ariya

Labels
Type:Tech Debt or Refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ariya