Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting return when modifying a custom expression incorrectly discards changes #15241

Closed
mazameli opened this issue Mar 19, 2021 · 2 comments
Closed
Assignees
Labels
Priority:P2 Average run of the mill bug Querying/Notebook Items specific to the Custom/Notebook query builder Type:Bug Product defects
Milestone

Comments

@mazameli
Copy link
Contributor

See this GIF example

  1. Create a filter expression in the notebook editor and click Done
  2. Click on the filter token to open up the popup to edit it
  3. Make some changes, then hit return/enter
  4. Your changes will be discarded instead of being applied.
@mazameli mazameli added Type:Bug Product defects Priority:P2 Average run of the mill bug Querying/Notebook Items specific to the Custom/Notebook query builder labels Mar 19, 2021
@ariya
Copy link
Contributor

ariya commented Mar 20, 2021

Here's another reproducing step:

  1. Ask a question, Custom question
  2. Sample dataset, Products table
  3. Add filters to narrow your search
  4. Choose Price, Greater than 1, click Add Filter
  5. Click on the new "Price is greater than 1" filter
  6. Click on the left chevron arrow, Custom Expression
  7. Complete the expression to [Price] > 1 AND [Price] < 5
  8. Press Enter

Expected:

There are two filters: "Price is greater than 1" and "Price is less than 5".

Actual:

There is only one filter: "Price is greater than 1".

@ariya
Copy link
Contributor

ariya commented Mar 23, 2021

Fixed with PR #15268.

@ariya ariya closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P2 Average run of the mill bug Querying/Notebook Items specific to the Custom/Notebook query builder Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

2 participants