Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom expression editor: fix Enter not committing the change #15268

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

ariya
Copy link
Contributor

@ariya ariya commented Mar 20, 2021

This fixes issue #15241. The solution is to ensure that the state change is synchronized with the commit event propagation.

To verify:

  1. Ask a question, Custom question
  2. Sample Dataset, Products table
  3. Add filters to narrow your search
  4. Choose Price, Greater than 1, click Add Filter
  5. Click on the new "Price is greater than 1" filter
  6. Click on the left chevron arrow, Custom Expression
  7. Complete the expression to [Price] > 1 AND [Price] < 5
  8. Press Enter

Before:

image

After:

image

@ariya ariya requested a review from daltojohnso March 22, 2021 18:56
Copy link
Contributor

@daltojohnso daltojohnso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants