-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drilling down to detail records from binned results, count doesn't match number of rows returned #15324
Labels
.Correctness
.Frontend
Priority:P2
Average run of the mill bug
Querying/GUI
Query builder catch-all, including simple mode
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Reproduced
Issues reproduced in test (usually Cypress)
.Team/QueryProcessor
:hammer_and_wrench:
Type:Bug
Product defects
Milestone
Comments
flamber
added
.Correctness
Priority:P2
Average run of the mill bug
Querying/GUI
Query builder catch-all, including simple mode
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
and removed
.Needs Triage
labels
Mar 25, 2021
nemanjaglumac
added a commit
that referenced
this issue
Mar 29, 2021
… match the number of records (#15381)
tsmacdonald
pushed a commit
that referenced
this issue
Apr 2, 2021
… match the number of records (#15381)
We definitely treat |
This was referenced Feb 20, 2023
This was referenced Feb 5, 2024
Closed
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.Correctness
.Frontend
Priority:P2
Average run of the mill bug
Querying/GUI
Query builder catch-all, including simple mode
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Reproduced
Issues reproduced in test (usually Cypress)
.Team/QueryProcessor
:hammer_and_wrench:
Type:Bug
Product defects
Describe the bug
Summarise a count by a binned numerical value, then selecting to drill down to "View these X", the number of rows returned doesn't always match the binned count. I think this is due to the edge conditions of the binned range and the filter value being set. The filter values are set to between the bin limits, values that equal the bin limit values are included in both the upper and lower binning drill downs.
Logs
Nothing of interest in the logs
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The number of rows returned by "View these X" should match the bin count
Screenshots
Binned summary:
Drilled to 10-20
Drilled to 20-30
You can see that the highlighted rows are in both drill downs.
Information about your Metabase Installation:
Severity
Inconsistency, leads to confusion and assuming that Metabase is getting it wrong, leads to loss of trust in it.
Additional context
Instead of using a between it should probably use the same logic as the binning which I assume is
>=
the lower limit, and<
the upper. Now I write it out I'm not sure ifbetween
behaviour is consistent across databases, in SQL Server it's inclusive of both limits.The text was updated successfully, but these errors were encountered: