Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit logging not able to show ad-hoc native query #16845

Closed
flamber opened this issue Jul 1, 2021 · 1 comment · Fixed by #18044
Closed

Audit logging not able to show ad-hoc native query #16845

flamber opened this issue Jul 1, 2021 · 1 comment · Fixed by #18044
Assignees
@kulyk
Labels
Administration/Metabase analytics Pro and Enterprise meta analytics, fka audit Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.41

Comments

@flamber
Copy link
Contributor

flamber commented Jul 1, 2021 •
edited

Describe the bug
Audit logging not able to show ad-hoc native query.

To Reproduce

  1. Native query > Sample Dataset > select 1 and run it
  2. Admin > Audit > Team members > Audit Log > click the top "Ad-hoc"
  3. The page refreshes without showing any results.
    It just shows "Something went wrong" constantly looping a reload of the frontend. This is a regression since 1.39.0.
Screencast-2021-07-01_11.48.20.mp4

Information about your Metabase Installation:
Tested 1.40.0-rc1

Additional context
Originally EE486 https://github.com/metabase/metabase-enterprise/issues/486
@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug Administration/Metabase analytics Pro and Enterprise meta analytics, fka audit labels Jul 1, 2021
@nemanjaglumac nemanjaglumac added the .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. label Jul 1, 2021
@flamber flamber removed the .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. label Jul 1, 2021
@kulyk kulyk added the .Reproduced Issues reproduced in test (usually Cypress) label Sep 24, 2021
@kulyk
Copy link
Member

kulyk commented Sep 24, 2021

Reproduced by this test

kulyk added a commit that referenced this issue Sep 24, 2021
@kulyk
Mention #16845 repro
f2cda41
@kulyk kulyk mentioned this issue Sep 24, 2021
Merged
kulyk added a commit that referenced this issue Sep 24, 2021
@kulyk
Fix Audit logging not showing ad-hoc native queries (#18044)
c51553d 
* Fix test's describe block

* Mention #16845 repro

* Assert native query text is displayed in Audit

* Enable the repro test

* Fix ad-hoc native query not displayed in Audit correctly

* Don't display native query sidebar in read-only mode
@flamber flamber added this to the 0.41 milestone Sep 24, 2021
@flamber flamber mentioned this issue Oct 13, 2021
Closed
@Tony-metabase Tony-metabase mentioned this issue Feb 22, 2023
Closed
This was referenced Jul 14, 2023
Closed
Merged
Open
@deploysentinel deploysentinel bot mentioned this issue Aug 7, 2023
Merged
This was referenced Aug 16, 2023
Merged
Merged
This was referenced Aug 28, 2023
Merged
Closed
This was referenced Oct 13, 2023
Merged
Merged
Merged
This was referenced Oct 25, 2023
Closed
Merged
@deploysentinel deploysentinel bot mentioned this issue Nov 10, 2023
Draft
@replay-io replay-io bot mentioned this issue Jan 11, 2024
Merged
This was referenced Apr 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
This was referenced May 7, 2024
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulyk kulyk

Labels
Administration/Metabase analytics Pro and Enterprise meta analytics, fka audit Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.41
Development

Successfully merging a pull request may close this issue.

Fix Audit logging not showing ad-hoc native queries metabase/metabase
3 participants
@flamber @kulyk @nemanjaglumac