Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to apply dashboard ID filter to a nested QB question #17212

Closed
nemanjaglumac opened this issue Jul 26, 2021 · 3 comments
Closed

Not possible to apply dashboard ID filter to a nested QB question #17212

nemanjaglumac opened this issue Jul 26, 2021 · 3 comments
Assignees
@daltojohnso
Labels
Priority:P2 Average run of the mill bug Querying/Nested Queries Questions based on other saved questions Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.43

Comments

@nemanjaglumac
Copy link
Member

Describe the bug
It is not possible to apply dashboard ID filter to a nested QB question. If you try that, UI will show "No valid fields" to connect to.

Logs
N/A

To Reproduce
Steps to reproduce the behavior:

  1. Open "Products" table from the "Sample Dataset" and save it as a question
  2. Ask new question > Custom > Saved > Choose previously saved "Products"
  3. Save it as "Products nested"
  4. When prompted, add nested question to the dashboard
  5. Add ID filter to the dashboard
  6. Observe that you cannot connect it to any of the fields.
    (I was trying to save the dashboard, refresh it... nothing helps)

Here comes the crazy part:
7. Add "regular" Products question to this same dashboard
8. All of a sudden, you can connect ID filter to both cards!
https://share.getcloudapp.com/rRuj4LO1

Expected behavior
It should be possible to use ID filter on a nested QB question

Screenshots
image

Information about your Metabase Installation:
local dev, H2, master

Severity
Feels like a solid P2.
@flamber flamber added Priority:P2 Average run of the mill bug Querying/Nested Queries Questions based on other saved questions Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards and removed .Needs Triage labels Jul 27, 2021
@flamber
Copy link
Contributor

flamber commented Jul 27, 2021 •
edited

Pretty sure it's a race-condition, so it's not always reproducible (note for devs).
Instead of adding the extra card, you can also save the dashboard, browser refresh, then edit the dashboard again.
Also, see #13186 (comment)

nemanjaglumac added a commit that referenced this issue Aug 6, 2021
@nemanjaglumac
Add repro for #17212
8b61ad0
@nemanjaglumac nemanjaglumac mentioned this issue Aug 6, 2021
Merged
nemanjaglumac added a commit that referenced this issue Aug 6, 2021
@nemanjaglumac
#17212 Repro: Not possible to apply dashboard ID filter to a nested Q…
c3e8a9c 
…B question (#17343)

* Add sane defaults to the card size in `createQuestionAndDashboard` custom command

* Add repro for #17212
github-actions bot pushed a commit that referenced this issue Aug 6, 2021
@nemanjaglumac
#17212 Repro: Not possible to apply dashboard ID filter to a nested Q…
cdb7914 
…B question (#17343)

* Add sane defaults to the card size in `createQuestionAndDashboard` custom command

* Add repro for #17212
nemanjaglumac added a commit that referenced this issue Aug 6, 2021
@github-actions @nemanjaglumac
#17212 Repro: Not possible to apply dashboard ID filter to a nested Q…
246cfeb 
…B question (#17343) (#17351)

* Add sane defaults to the card size in `createQuestionAndDashboard` custom command

* Add repro for #17212

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Aug 6, 2021
@naomiaro naomiaro mentioned this issue Sep 29, 2021
Open
@flamber
Copy link
Contributor

flamber commented Apr 23, 2022

@nemanjaglumac Are you able to reproduce this anymore on 43? There has been so many small changes, which fixed possible race-conditions. But it could still be problems with result_metadata.

@nemanjaglumac
Copy link
Member Author

@nemanjaglumac Are you able to reproduce this anymore on 43? There has been so many small changes, which fixed possible race-conditions. But it could still be problems with result_metadata.

@flamber nope. Just tried it and cannot reproduce.

nemanjaglumac added a commit that referenced this issue Apr 24, 2022
@nemanjaglumac
Unskip repro for #17212
0702936
@flamber flamber added this to the 0.43 milestone Apr 24, 2022
@flamber flamber closed this as completed Apr 24, 2022
nemanjaglumac added a commit that referenced this issue Apr 24, 2022
@nemanjaglumac
Unskip repro for #17212 (#21986)
7a0c4f0
nemanjaglumac added a commit that referenced this issue Apr 25, 2022
@nemanjaglumac
Unskip repro for #17212 (#21986)
43481de
nemanjaglumac added a commit that referenced this issue Apr 25, 2022
@nemanjaglumac
🍒 Backport E2E dashboard-filters changes (#21995)
53f8cff 
* Unskip repro for #17212 (#21986)

* [E2E] Merge dashboard filters (#21987)

* Merge dashboard filters

* Run merged dashboard filters in CI

* Remove `dashboard-filters-sql` from E2E on `master`

* [E2E] Remove dashboard filters check from CCI (#21991)
@deploysentinel deploysentinel bot mentioned this issue Jan 10, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Jan 19, 2023
Closed
@deploysentinel deploysentinel bot mentioned this issue Feb 8, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Feb 16, 2023
Merged
This was referenced Jan 11, 2024
Merged
Merged
This was referenced May 7, 2024
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daltojohnso daltojohnso

Labels
Priority:P2 Average run of the mill bug Querying/Nested Queries Questions based on other saved questions Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.43
Development

No branches or pull requests
3 participants
@flamber @daltojohnso @nemanjaglumac