Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible columns list in table options sidebar does not respect renamed columns #18476

Closed
noahmoss opened this issue Oct 14, 2021 · 0 comments · Fixed by #29141
Closed

Visible columns list in table options sidebar does not respect renamed columns #18476

noahmoss opened this issue Oct 14, 2021 · 0 comments · Fixed by #29141
Assignees
Labels
.Completeness Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Chart Settings

Comments

@noahmoss
Copy link
Member

Describe the bug
If you change the name of a column in a table, the table options sidebar will still use the original name, not the new name. This can be confusing if all the columns are renamed and you forget how they correspond to the original names (or you weren't the one who renamed them).

To Reproduce
Steps to reproduce the behavior:

  1. Go to a table
  2. Click on Settings
  3. Click on the gear icon for a column
  4. Rename the column
  5. Go back to the general table settings sidebar
  6. Observe that the Visible columns list doesn't use the new name

Expected behavior
The list should use the user-defined column names

Information about your Metabase Installation:

Current master

@noahmoss noahmoss added Type:Bug Product defects .Needs Triage labels Oct 14, 2021
@nemanjaglumac nemanjaglumac added this to Backlog in Cypress Testing Oct 15, 2021
nemanjaglumac added a commit that referenced this issue Oct 16, 2021
nemanjaglumac added a commit that referenced this issue Oct 17, 2021
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Oct 17, 2021
github-actions bot pushed a commit that referenced this issue Oct 17, 2021
nemanjaglumac pushed a commit that referenced this issue Oct 17, 2021
@ariya ariya self-assigned this Mar 22, 2022
@nemanjaglumac nemanjaglumac removed this from Backlog in Cypress Testing Jan 11, 2023
@npfitz npfitz self-assigned this Mar 10, 2023
@npfitz npfitz mentioned this issue Mar 10, 2023
1 task
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Completeness Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Chart Settings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants