Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remapped columns do not use renamed titles in XLSX exports #18573

Closed
noahmoss opened this issue Oct 20, 2021 · 2 comments · Fixed by #22212
Closed

Remapped columns do not use renamed titles in XLSX exports #18573

noahmoss opened this issue Oct 20, 2021 · 2 comments · Fixed by #22212
Assignees
@noahmoss
Labels
.Correctness Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Remapping Remapped display values, whether human-readable values or Field->Field remappings Reporting/Export .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.43

Comments

@noahmoss
Copy link
Member

Describe the bug
If a column uses remapped values, and is renamed, an XLSX export will not use the new name

To Reproduce
Steps to reproduce the behavior:

  1. In the data model settings, change a column to use remapped values
  2. In a question using a table visualization, rename the remapped column
  3. Export as XLSX

Expected behavior
Column name should match what is shown in Metabase exactly

Information about your Metabase Installation:
Current master
@noahmoss noahmoss added Type:Bug Product defects .Needs Triage labels Oct 20, 2021
@flamber flamber added .Correctness Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Export and removed .Needs Triage labels Oct 20, 2021
@nemanjaglumac
Copy link
Member

Related?
#18440

@flamber
Copy link
Contributor

flamber commented Nov 1, 2021 •
edited

@nemanjaglumac A tiny bit, but that issue was about dropped columns (P1), while this is the column title. It was discussed during fixing of that issue, where a couple of issues were created - see PR #18490.

But very related to #18572

nemanjaglumac added a commit that referenced this issue Nov 1, 2021
@nemanjaglumac
Add repro for #18573
1bbbd16
@nemanjaglumac nemanjaglumac mentioned this issue Nov 1, 2021
Merged
nemanjaglumac added a commit that referenced this issue Nov 1, 2021
@nemanjaglumac
#18573 Repro: Remapped columns do not use renamed titles in exports (#…
a459f19 
…18793)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Nov 1, 2021
github-actions bot pushed a commit that referenced this issue Nov 1, 2021
@nemanjaglumac
#18573 Repro: Remapped columns do not use renamed titles in exports (#…
56640b9 
…18793)
nemanjaglumac added a commit that referenced this issue Nov 1, 2021
@github-actions @nemanjaglumac
#18573 Repro: Remapped columns do not use renamed titles in exports (#…
fcebecf 
…18793) (#18797)

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
@camsaul camsaul added the Querying/Remapping Remapped display values, whether human-readable values or Field->Field remappings label Jan 20, 2022
@rlotun rlotun assigned noahmoss and unassigned escherize Apr 15, 2022
@noahmoss noahmoss mentioned this issue Apr 28, 2022
Merged
@flamber flamber added this to the 0.43 milestone Apr 30, 2022
This was referenced Nov 28, 2022
Open
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 6, 2023
Merged
1 task
@deploysentinel deploysentinel bot mentioned this issue Apr 12, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue May 22, 2023
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahmoss noahmoss

Labels
.Correctness Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Remapping Remapped display values, whether human-readable values or Field->Field remappings Reporting/Export .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.43
Development

Successfully merging a pull request may close this issue.

Fix XLSX column names for remapped cols metabase/metabase
5 participants
@escherize @flamber @camsaul @nemanjaglumac @noahmoss