Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-ray card links & drill-throughs are broken #19405

Closed
noahmoss opened this issue Dec 17, 2021 · 2 comments · Fixed by #19436
Closed

X-ray card links & drill-throughs are broken #19405

noahmoss opened this issue Dec 17, 2021 · 2 comments · Fixed by #19436
Assignees
Labels
Priority:P2 Average run of the mill bug Querying/X-rays .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects

Comments

@noahmoss
Copy link
Member

noahmoss commented Dec 17, 2021

Describe the bug
If you're viewing an (unsaved) X-ray, and you click on the title of any card, it takes you to the "Ask a question" page with the simple question/custom question/native query prompts, rather than taking you to the specific question that you clicked on.

And if you try to do a drill-through or breakout on any card on the X-ray, it'll take you to a 404 page.

Untitled.mov

To Reproduce
Steps to reproduce the behavior:

  1. Go to Browse data -> Sample Dataset
  2. Click on "X-ray this table" for any table
  3. Click on the title of any card in the X-ray, or click on any piece of data in a chart and select any of the options

Expected behavior
Links should take you directly to the question you clicked on

Information about your Metabase Installation:
Current master (& can repro on stats)

@noahmoss noahmoss added Type:Bug Product defects .Needs Triage labels Dec 17, 2021
@flamber flamber added .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Priority:P2 Average run of the mill bug Querying/X-rays and removed .Needs Triage labels Dec 18, 2021
@flamber
Copy link
Contributor

flamber commented Dec 18, 2021

Regression on master. Works on 0.41.5.
Wonder if it might be caused by some of the drill-through/filter changes @daltojohnso made recently? Perhaps X-rays are using old-style?

@daltojohnso
Copy link
Contributor

Yep, caused by #19027. X-ray dashcards are a special case that needs to be handled differently.

@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P2 Average run of the mill bug Querying/X-rays .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants