-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Slack App does not allow selecting private channels for pulses #20867
Comments
My 2¢:
But someone like @brunobergher should probably weigh in here from the product side. |
I agree with @noahmoss on all points. I have seen a UX pattern elsewhere where users can enter a channel id if the channel they're looking for isn't in the list, which could help alleviate this (eg making the last option in the list |
Just wanted to share another perspective. At our organization, private channels do not necessarily equate to "where the secrets live"; instead, it's more akin to "we prefer not to have random people join and ask questions in this channel". In this world, most of our team-specific channels are private. These are also the destinations for most of our pulses. I suspect we're not that unusual in using Slack this way. In any case, our other SaaS tools will happily send to private channels, so with the recent update Metabase has become the odd man out. I hope you'll consider an option that doesn't require editing the database directly. As is, I'd consider this a regression in the Slack integration. My preference would be to retain the groups:read permission and conditionally show a stern warning in the UI when setting up a pulse to a private channel. |
Categorizing as a frontend bug, since a fix to this should be to change the Slack UI to allow free-form input alongside the channel drop-down. If this is done, the backend should work without issue. |
@brunobergher @cdeweyx, I'm taking up this issue per our pod's weekly planning. Bruno, Conor suggested we implement the option of posting to private channels the way you suggest above. One detail we may want to think about: "making the last option in the list Other (enter id)". The list of public channels / @s to post may get very large, enough to make the last option nearly undiscoverable. Alternatives I can quickly think of:
Any thoughts? |
Works great for dashboards, but don't see any change in setting alerts for a question. |
@abhishek-superk There's now an issue for it #23483. |
@flamber : Thankyou, much appreciated! |
Is your feature request related to a problem? Please describe.
With the old Slack bot integration it used to be possible to select a private channel for pulses in Slack. This option is now gone with the introduction of the new Slack App.
Describe the solution you'd like
We would like for it to, once again, be possible to select private channels when setting up a Slack pulse.
Describe alternatives you've considered
A workaround was suggested in #2694 here, but it seems a bit too bad, as this was possible with the old integration.
It has also been suggested to just make the text field free form, so private channels can be added directly by name (and then might just not exist). This solution would also work, but the UX of having them available in the dropdown as before seems nicer.
How important is this feature to you?
We do not use pulses for anything but posting to private channels, as it is only select people who needs the info. Right now we did the manual DB edit as in the workaround. It was historically also a very popular addition in #2694, so it seems like a lot of people will miss this option.
Additional context
I found that the decision to remove list of
private_channel
was made here. It was done to reduce the need of the scopegroups:read
, which is a bit too bad. I would like to note that this scope still only gives the app read access to private channels it has been added to. I verified this using theconversations.list
endpoint. So the scope does not give excessive access to lots of unneeded information.Just thought I would raise this as its own issue, to show that we would very much like this option to still be available.
⬇️ Please click the 👍 reaction instead of leaving a
+1
orupdate?
commentThe text was updated successfully, but these errors were encountered: