Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal users can't create first snippet in Enterprise version #21581

Closed
paoliniluis opened this issue Apr 11, 2022 · 2 comments · Fixed by #21940
Closed

Normal users can't create first snippet in Enterprise version #21581

paoliniluis opened this issue Apr 11, 2022 · 2 comments · Fixed by #21940
Assignees
Labels
Administration/Permissions Collection or Data permissions .Backend Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@paoliniluis
Copy link
Contributor

Describe the bug
On a brand new Enterprise install, users don't have the ability to create snippets by default.
In addition, in order to grant access, an admin has to first create a snippet, then change the root permissions.

Logs
NA

To Reproduce

  1. Set up a new instance on Enterprise
  2. create a normal user
  3. logged in as the normal user, try to create the first snippet, see the error

Expected behavior
Unless there's an explicit permission set by an administrator, normal users should be able to create a snippet

Screenshots
image

Information about your Metabase Installation:

  • Your browser and the version: Brave latest
  • Your operating system: Ubuntu 20.04.4
  • Your databases: Postgres 14
  • Metabase version: 1.42.3
  • Metabase hosting environment: Docker
  • Metabase internal database: Postgres 14

Severity
Annoying

Additional context
NA

@paoliniluis paoliniluis added Type:Bug Product defects Priority:P2 Average run of the mill bug Administration/Permissions Collection or Data permissions Querying/Native The SQL/native query editor labels Apr 11, 2022
@flamber flamber added the Querying/Parameters & Variables Filter widgets, field filters, variables etc. label Apr 11, 2022
@nemanjaglumac nemanjaglumac added this to Backlog in Cypress Testing via automation Apr 11, 2022
@nemanjaglumac
Copy link
Member

@paoliniluis and @flamber this was labeled as Type:New Feature back in the EE days. There is even a test that made sure this behavior is currently expected.
https://github.com/metabase/metabase/blob/master/frontend/test/metabase/scenarios/native/snippets/snippet-permissions.cy.spec.js#L32:L51

Also, look at the comment in this spec:
https://github.com/metabase/metabase/blob/master/frontend/test/metabase/scenarios/native/snippets/snippets.cy.spec.js

@flamber
Copy link
Contributor

flamber commented Apr 12, 2022

@nemanjaglumac Things have changed. EE build is being used elsewhere. This should always have been a bug.

Related to #20316 and #21549

nemanjaglumac added a commit that referenced this issue Apr 12, 2022
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Apr 12, 2022
@nemanjaglumac nemanjaglumac removed this from Backlog in Cypress Testing Apr 18, 2022
@qnkhuat qnkhuat self-assigned this Apr 22, 2022
@flamber flamber added this to the 0.44 milestone Jun 22, 2022
This was referenced Feb 5, 2024
@replay-io replay-io bot mentioned this issue Mar 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Permissions Collection or Data permissions .Backend Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants