Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include this quarter action is missing the words "this quarter" #22224

Closed
mazameli opened this issue Apr 28, 2022 · 0 comments · Fixed by #22321
Closed

Include this quarter action is missing the words "this quarter" #22224

mazameli opened this issue Apr 28, 2022 · 0 comments · Fixed by #22321
Assignees
@akiselev
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. Type:Bug Product defects
Milestone
0.43

Comments

@mazameli
Copy link
Contributor

When the granularity for a relative filter is set to Quarter, the include-current-period action currently just says "Include." It should read Include this quarter.

image

This has been a problem since version 0.42 at least:

image
@mazameli mazameli added Type:Bug Product defects Querying/GUI Query builder catch-all, including simple mode .Needs Triage .bugbash labels Apr 28, 2022
@flamber flamber added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Frontend and removed .Needs Triage labels May 1, 2022
@akiselev akiselev mentioned this issue May 2, 2022
Merged
@rlotun rlotun added this to the 0.43 milestone May 2, 2022
akiselev pushed a commit that referenced this issue May 2, 2022
Fix several bugs in relative datetime filters (#22321)
76b1734 
**Changing the granularity of the `Past`/`Next` range picker now changes the granularity of the `Starting from` option**
  - Fixes #22222
  - Reproduces #22222 

---

**`Include this quarter` now displays correctly**
  - Fixes #22224 

---

**Now shows the correct date preview in `Past`/`Next` range picker**
  - Fixes #22225 
  - Reproduces #22225 

---

**Can now change `Past`/`Next` granularity when the value is set to `1`**
  - Fixes #22227
  - Reproduces #22227

---

**`Next` relative filter pill text now reads `from now` instead of `ago`**
  - Fixes #22228
  - Reproduces #22228
github-actions bot pushed a commit that referenced this issue May 2, 2022
Fix several bugs in relative datetime filters (#22321)
8244c75 
**Changing the granularity of the `Past`/`Next` range picker now changes the granularity of the `Starting from` option**
  - Fixes #22222
  - Reproduces #22222 

---

**`Include this quarter` now displays correctly**
  - Fixes #22224 

---

**Now shows the correct date preview in `Past`/`Next` range picker**
  - Fixes #22225 
  - Reproduces #22225 

---

**Can now change `Past`/`Next` granularity when the value is set to `1`**
  - Fixes #22227
  - Reproduces #22227

---

**`Next` relative filter pill text now reads `from now` instead of `ago`**
  - Fixes #22228
  - Reproduces #22228
akiselev pushed a commit that referenced this issue May 2, 2022
@github-actions
Fix several bugs in relative datetime filters (#22321) (#22336)
3aa65a0 
**Changing the granularity of the `Past`/`Next` range picker now changes the granularity of the `Starting from` option**
  - Fixes #22222
  - Reproduces #22222 

---

**`Include this quarter` now displays correctly**
  - Fixes #22224 

---

**Now shows the correct date preview in `Past`/`Next` range picker**
  - Fixes #22225 
  - Reproduces #22225 

---

**Can now change `Past`/`Next` granularity when the value is set to `1`**
  - Fixes #22227
  - Reproduces #22227

---

**`Next` relative filter pill text now reads `from now` instead of `ago`**
  - Fixes #22228
  - Reproduces #22228

Co-authored-by: Alexander Kiselev <alexander.kiselev@metabase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akiselev akiselev

Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. Type:Bug Product defects
Projects
None yet
Milestone
0.43
Development

Successfully merging a pull request may close this issue.

Fix several bugs in relative datetime filters metabase/metabase
4 participants
@rlotun @akiselev @flamber @mazameli